From 6732aa9725f0de73515099b650e25d26fedd853e Mon Sep 17 00:00:00 2001 From: vilmibm Date: Wed, 12 Feb 2020 08:48:25 -0600 Subject: [PATCH] fix tests --- command/issue_test.go | 218 ++++------------------------ command/pr_test.go | 328 ++++-------------------------------------- command/root.go | 1 + command/testing.go | 3 + 4 files changed, 61 insertions(+), 489 deletions(-) diff --git a/command/issue_test.go b/command/issue_test.go index afc0d0c2e..edce87fb6 100644 --- a/command/issue_test.go +++ b/command/issue_test.go @@ -9,33 +9,14 @@ import ( "regexp" "testing" - "github.com/cli/cli/context" "github.com/cli/cli/utils" ) func TestIssueStatus(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() + http.StubRepoResponse("OWNER", "REPO") - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) jsonFile, _ := os.Open("../test/fixtures/issueStatus.json") defer jsonFile.Close() http.StubResponse(200, jsonFile) @@ -61,28 +42,9 @@ func TestIssueStatus(t *testing.T) { } func TestIssueStatus_blankSlate(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { @@ -117,28 +79,9 @@ Issues opened by you } func TestIssueStatus_disabledIssues(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { @@ -153,28 +96,9 @@ func TestIssueStatus_disabledIssues(t *testing.T) { } func TestIssueList(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") jsonFile, _ := os.Open("../test/fixtures/issueList.json") defer jsonFile.Close() @@ -200,28 +124,9 @@ func TestIssueList(t *testing.T) { } func TestIssueList_withFlags(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { @@ -242,7 +147,7 @@ Issues for OWNER/REPO No issues match your search `) - bodyBytes, _ := ioutil.ReadAll(http.Requests[0].Body) + bodyBytes, _ := ioutil.ReadAll(http.Requests[1].Body) reqBody := struct { Variables struct { Assignee string @@ -258,28 +163,9 @@ No issues match your search } func TestIssueList_nullAssigneeLabels(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { @@ -293,7 +179,7 @@ func TestIssueList_nullAssigneeLabels(t *testing.T) { t.Errorf("error running command `issue list`: %v", err) } - bodyBytes, _ := ioutil.ReadAll(http.Requests[0].Body) + bodyBytes, _ := ioutil.ReadAll(http.Requests[1].Body) reqBody := struct { Variables map[string]interface{} }{} @@ -308,6 +194,7 @@ func TestIssueList_nullAssigneeLabels(t *testing.T) { func TestIssueList_disabledIssues(t *testing.T) { initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { @@ -324,6 +211,7 @@ func TestIssueList_disabledIssues(t *testing.T) { func TestIssueView(t *testing.T) { initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { "hasIssuesEnabled": true, "issue": { @@ -357,6 +245,7 @@ func TestIssueView(t *testing.T) { func TestIssueView_preview(t *testing.T) { initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { "hasIssuesEnabled": true, "issue": { @@ -429,6 +318,7 @@ func TestIssueView_notFound(t *testing.T) { func TestIssueView_disabledIssues(t *testing.T) { initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { @@ -446,6 +336,7 @@ func TestIssueView_disabledIssues(t *testing.T) { func TestIssueView_urlArg(t *testing.T) { initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { "hasIssuesEnabled": true, "issue": { @@ -476,28 +367,9 @@ func TestIssueView_urlArg(t *testing.T) { } func TestIssueCreate(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { @@ -516,7 +388,7 @@ func TestIssueCreate(t *testing.T) { t.Errorf("error running command `issue create`: %v", err) } - bodyBytes, _ := ioutil.ReadAll(http.Requests[1].Body) + bodyBytes, _ := ioutil.ReadAll(http.Requests[2].Body) reqBody := struct { Variables struct { Input struct { @@ -536,28 +408,9 @@ func TestIssueCreate(t *testing.T) { } func TestIssueCreate_disabledIssues(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { @@ -573,28 +426,9 @@ func TestIssueCreate_disabledIssues(t *testing.T) { } func TestIssueCreate_web(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") var seenCmd *exec.Cmd restoreCmd := utils.SetPrepareCmd(func(cmd *exec.Cmd) utils.Runnable { diff --git a/command/pr_test.go b/command/pr_test.go index d194cf726..f0069371f 100644 --- a/command/pr_test.go +++ b/command/pr_test.go @@ -11,7 +11,6 @@ import ( "strings" "testing" - "github.com/cli/cli/context" "github.com/cli/cli/utils" "github.com/google/shlex" "github.com/spf13/cobra" @@ -72,28 +71,9 @@ func RunCommand(cmd *cobra.Command, args string) (*cmdOut, error) { } func TestPRStatus(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("blueberries") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "blueberries") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") jsonFile, _ := os.Open("../test/fixtures/prStatus.json") defer jsonFile.Close() @@ -119,28 +99,9 @@ func TestPRStatus(t *testing.T) { } func TestPRStatus_reviewsAndChecks(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("blueberries") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "blueberries") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") jsonFile, _ := os.Open("../test/fixtures/prStatusChecks.json") defer jsonFile.Close() @@ -165,28 +126,9 @@ func TestPRStatus_reviewsAndChecks(t *testing.T) { } func TestPRStatus_blankSlate(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("blueberries") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "blueberries") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": {} } @@ -216,28 +158,9 @@ Requesting a code review from you } func TestPRList(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") jsonFile, _ := os.Open("../test/fixtures/prList.json") defer jsonFile.Close() @@ -255,28 +178,9 @@ func TestPRList(t *testing.T) { } func TestPRList_filtering(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") respBody := bytes.NewBufferString(`{ "data": {} }`) http.StubResponse(200, respBody) @@ -293,7 +197,7 @@ Pull requests for OWNER/REPO No pull requests match your search `) - bodyBytes, _ := ioutil.ReadAll(http.Requests[0].Body) + bodyBytes, _ := ioutil.ReadAll(http.Requests[1].Body) reqBody := struct { Variables struct { State []string @@ -307,28 +211,9 @@ No pull requests match your search } func TestPRList_filteringAssignee(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") respBody := bytes.NewBufferString(`{ "data": {} }`) http.StubResponse(200, respBody) @@ -338,7 +223,7 @@ func TestPRList_filteringAssignee(t *testing.T) { t.Fatal(err) } - bodyBytes, _ := ioutil.ReadAll(http.Requests[0].Body) + bodyBytes, _ := ioutil.ReadAll(http.Requests[1].Body) reqBody := struct { Variables struct { Q string @@ -352,6 +237,7 @@ func TestPRList_filteringAssignee(t *testing.T) { func TestPRList_filteringAssigneeLabels(t *testing.T) { initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() + http.StubRepoResponse("OWNER", "REPO") respBody := bytes.NewBufferString(`{ "data": {} }`) http.StubResponse(200, respBody) @@ -363,28 +249,9 @@ func TestPRList_filteringAssigneeLabels(t *testing.T) { } func TestPRView_preview(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") jsonFile, _ := os.Open("../test/fixtures/prViewPreview.json") defer jsonFile.Close() @@ -412,28 +279,9 @@ func TestPRView_preview(t *testing.T) { } func TestPRView_previewCurrentBranch(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("blueberries") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "blueberries") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") jsonFile, _ := os.Open("../test/fixtures/prView.json") defer jsonFile.Close() @@ -466,28 +314,9 @@ func TestPRView_previewCurrentBranch(t *testing.T) { } func TestPRView_currentBranch(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("blueberries") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "blueberries") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") jsonFile, _ := os.Open("../test/fixtures/prView.json") defer jsonFile.Close() @@ -523,28 +352,9 @@ func TestPRView_currentBranch(t *testing.T) { } func TestPRView_noResultsForBranch(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("blueberries") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "blueberries") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") jsonFile, _ := os.Open("../test/fixtures/prView_NoActiveBranch.json") defer jsonFile.Close() @@ -573,28 +383,9 @@ func TestPRView_noResultsForBranch(t *testing.T) { } func TestPRView_numberArg(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { "pullRequest": { @@ -624,28 +415,9 @@ func TestPRView_numberArg(t *testing.T) { } func TestPRView_urlArg(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { "pullRequest": { @@ -675,28 +447,9 @@ func TestPRView_urlArg(t *testing.T) { } func TestPRView_branchArg(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { "pullRequests": { "nodes": [ @@ -728,28 +481,9 @@ func TestPRView_branchArg(t *testing.T) { } func TestPRView_branchWithOwnerArg(t *testing.T) { - ctx := context.NewBlank() - ctx.SetBranch("master") - ctx.SetRemotes(map[string]string{ - "origin": "OWNER/REPO", - }) - initContext = func() context.Context { - return ctx - } + initBlankContext("OWNER/REPO", "master") http := initFakeHTTP() - - http.StubResponse(200, bytes.NewBufferString(` - { "data": { "repo_000": { - "id": "REPOID", - "name": "REPO", - "owner": {"login": "OWNER"}, - "defaultBranchRef": { - "name": "master", - "target": {"oid": "deadbeef"} - }, - "viewerPermission": "WRITE" - } } } - `)) + http.StubRepoResponse("OWNER", "REPO") http.StubResponse(200, bytes.NewBufferString(` { "data": { "repository": { "pullRequests": { "nodes": [ diff --git a/command/root.go b/command/root.go index 7b9b62ce1..0864bfca7 100644 --- a/command/root.go +++ b/command/root.go @@ -173,6 +173,7 @@ func determineBaseRepo(cmd *cobra.Command, ctx context.Context) (*ghrepo.Interfa if err != nil { return nil, err } + var baseRepo ghrepo.Interface baseRepo, err = repoContext.BaseRepo() if err != nil { diff --git a/command/testing.go b/command/testing.go index 370ba7b53..206c8517d 100644 --- a/command/testing.go +++ b/command/testing.go @@ -12,6 +12,9 @@ func initBlankContext(repo, branch string) { ctx := context.NewBlank() ctx.SetBaseRepo(repo) ctx.SetBranch(branch) + ctx.SetRemotes(map[string]string{ + "origin": "OWNER/REPO", + }) return ctx } }