STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cleaned up, added suggestion to 404 handling

Browse source
This commit is contained in:
bchadwic 2021-05-24 13:06:33 -07:00
parent fdca340b28
commit 70e72afdcc
1 changed files with 9 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

18
pkg/cmd/browse/browse.go
View file

@ -94,7 +94,7 @@ func openInBrowser(cmd *cobra.Command, opts *BrowseOptions) {
} else if opts.WikiFlag {
repoUrl += "/wiki"
}
opts.Browser.Browse(repoUrl)
opts.Browser.Browse(repoUrl) // ATTN this is where we could check to see if the repoUrl has a 404 before proceeding
printExit(exitSuccess, cmd, opts, repoUrl)
return
}
@ -116,6 +116,7 @@ func parseArgs(opts *BrowseOptions) {
func printExit(errorCode exitCode, cmd *cobra.Command, opts *BrowseOptions, url string) {
w := opts.IO.ErrOut
cs := opts.IO.ColorScheme()
help := "Use 'gh browse --help' for more information about browse\n"
switch errorCode {
case exitSuccess:
@ -124,23 +125,22 @@ func printExit(errorCode exitCode, cmd *cobra.Command, opts *BrowseOptions, url
opts.IO.ColorScheme().Bold(url))
break
case exitNotInRepo:
fmt.Fprintf(w, "%s Change directory to a repository to open in browser\nUse 'gh browse --help' for more information about browse\n",
cs.Red("x"))
fmt.Fprintf(w, "%s Change directory to a repository to open in browser\n%s",
cs.Red("x"), help)
break
case exitTooManyFlags:
fmt.Fprintf(w, "%s accepts 1 flag, %d flags were recieved\nUse 'gh browse --help' for more information about browse\n",
cs.Red("x"), getFlagAmount(cmd))
fmt.Fprintf(w, "%s accepts 1 flag, %d flags were recieved\n%s",
cs.Red("x"), getFlagAmount(cmd), help)
break
case exitError:
fmt.Fprintf(w, "%s Incorrect use of arguments and flags\nUse 'gh browse --help' for more information about browse\n",
cs.Red("x"))
fmt.Fprintf(w, "%s Incorrect use of arguments and flags\n%s",
cs.Red("x"), help)
break
}
}
func hasArgs(opts *BrowseOptions) bool {
return opts.SelectorArg != ""
return opts.NumberArg != 0 || opts.FileArg != ""
}
func getFlagAmount(cmd *cobra.Command) int {