STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

review suggestions

Browse source
This commit is contained in:
Bernardo 2022-03-03 18:40:00 +00:00 • committed by GitHub
parent 383a711902
commit 7656943c31
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

4
pkg/cmd/codespace/ports.go
View file

@ -285,7 +285,7 @@ func (a *App) UpdatePortVisibility(ctx context.Context, codespaceName string, ar
ctx, cancel := context.WithTimeout(ctx, 30*time.Second)
defer cancel()
go func() {
go func(port portVisibility) {
updateNotif, err := session.WaitForPortNotification(ctx, port.number, liveshare.PortChangeKindUpdate)
if err != nil {
errc <- fmt.Errorf("error waiting for port %d to update: %w", port.number, err)
@ -300,7 +300,7 @@ func (a *App) UpdatePortVisibility(ctx context.Context, codespaceName string, ar
return
}
errc <- nil // success
}()
}(port)
err := session.UpdateSharedServerPrivacy(ctx, port.number, port.visibility)
if err != nil {

10
pkg/cmd/codespace/ports_test.go
View file

@ -48,7 +48,7 @@ func TestPortsUpdateVisibilitySuccess(t *testing.T) {
},
}
err := runUpdateVisibilityTest(portVisibilities, eventResponses, portsData)
err := runUpdateVisibilityTest(t, portVisibilities, eventResponses, portsData)
if err != nil {
t.Errorf("unexpected error: %v", err)
@ -91,7 +91,7 @@ func TestPortsUpdateVisibilityFailure403(t *testing.T) {
},
}
err := runUpdateVisibilityTest(portVisibilities, eventResponses, portsData)
err := runUpdateVisibilityTest(t, portVisibilities, eventResponses, portsData)
if err == nil {
t.Errorf("unexpected error: %v", err)
}
@ -136,7 +136,7 @@ func TestPortsUpdateVisibilityFailure(t *testing.T) {
},
}
err := runUpdateVisibilityTest(portVisibilities, eventResponses, portsData)
err := runUpdateVisibilityTest(t, portVisibilities, eventResponses, portsData)
if err == nil {
t.Errorf("unexpected error: %v", err)
}
@ -151,7 +151,9 @@ type joinWorkspaceResult struct {
SessionNumber int `json:"sessionNumber"`
}
func runUpdateVisibilityTest(portVisibilities []portVisibility, eventResponses []string, portsData []liveshare.PortNotification) error {
func runUpdateVisibilityTest(t *testing.T, portVisibilities []portVisibility, eventResponses []string, portsData []liveshare.PortNotification) error {
t.Helper()
joinWorkspace := func(req *jsonrpc2.Request) (interface{}, error) {
return joinWorkspaceResult{1}, nil
}