STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #9577 from cli/move-non-integration-test

Browse source 
Move non-integration tests to different test file
This commit is contained in:
William Martin 2024-09-10 15:43:25 +02:00 • committed by GitHub
commit 78c1d00ecc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
pkg/cmd/attestation/verification/attestation_test.go
View file

@ -87,6 +87,18 @@ func TestGetLocalAttestations(t *testing.T) {
require.ErrorIs(t, err, ErrUnrecognisedBundleExtension)
require.Nil(t, attestations)
})
t.Run("with missing verification material", func(t *testing.T) {
path := "../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-verification-material.jsonl"
_, err := GetLocalAttestations(path)
require.ErrorContains(t, err, "missing verification material")
})
t.Run("with missing verification certificate", func(t *testing.T) {
path := "../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-cert.jsonl"
_, err := GetLocalAttestations(path)
require.ErrorContains(t, err, "missing bundle content")
})
}
func TestFilterAttestations(t *testing.T) {

10
pkg/cmd/attestation/verification/sigstore_integration_test.go
View file

@ -42,16 +42,6 @@ func TestLiveSigstoreVerifier(t *testing.T) {
require.NoError(t, res.Error)
})
t.Run("with missing verification material", func(t *testing.T) {
_, err := GetLocalAttestations("../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-verification-material.jsonl")
require.ErrorContains(t, err, "missing verification material")
})
t.Run("with missing verification certificate", func(t *testing.T) {
_, err := GetLocalAttestations("../test/data/github_provenance_demo-0.0.12-py3-none-any-bundle-missing-cert.jsonl")
require.ErrorContains(t, err, "missing bundle content")
})
t.Run("with GitHub Sigstore artifact", func(t *testing.T) {
githubArtifactPath := test.NormalizeRelativePath("../test/data/github_provenance_demo-0.0.12-py3-none-any.whl")
githubArtifact, err := artifact.NewDigestedArtifact(nil, githubArtifactPath, "sha256")