STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

tyop fix + stricter switch

Browse source
This commit is contained in:
vilmibm 2020-05-11 17:39:52 -05:00
parent a7bcfffdd3
commit 79ad1ed5d3
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
command/pr_review.go
View file

@ -194,13 +194,17 @@ func reviewSurvey(cmd *cobra.Command) (*api.PullRequestReviewInput, error) {
return nil, err return nil, err
} }
reviewState := api.ReviewComment var reviewState api.PullRequestReviewState
switch typeAnswers.ReviewType { switch typeAnswers.ReviewType {
case "Approve": case "Approve":
reviewState = api.ReviewApprove reviewState = api.ReviewApprove
case "Request Changes": case "Request changes":
reviewState = api.ReviewRequestChanges reviewState = api.ReviewRequestChanges
case "Comment":
reviewState = api.ReviewComment
default:
panic("unreachable state")
} }
bodyAnswers := struct { bodyAnswers := struct {

2
command/pr_review_test.go
View file

@ -315,7 +315,7 @@ func TestPRReview_interactive_no_body(t *testing.T) {
as.Stub([]*QuestionStub{ as.Stub([]*QuestionStub{
{ {
Name: "reviewType", Name: "reviewType",
Value: "Request Changes", Value: "Request changes",
}, },
}) })
as.Stub([]*QuestionStub{ as.Stub([]*QuestionStub{