From 7d4ab65af3f7b28b1db760c3a730fadfacf24941 Mon Sep 17 00:00:00 2001 From: Alex Petrov Date: Sun, 5 Mar 2023 17:16:29 -0500 Subject: [PATCH] fix: correctly set `ErrNotOnAnyBranch` error in git client (#7082) Before, git client was not correctly setting `ErrNotOnAnyBranch` error. Because of that, `gh pr status` was not functioning correctly when run from the detached HEAD. This commit fixes that. Fixes #7051 --- git/client.go | 1 + 1 file changed, 1 insertion(+) diff --git a/git/client.go b/git/client.go index b45ce9138..43c94fef1 100644 --- a/git/client.go +++ b/git/client.go @@ -142,6 +142,7 @@ func (c *Client) CurrentBranch(ctx context.Context) (string, error) { if err != nil { var gitErr *GitError if ok := errors.As(err, &gitErr); ok && len(gitErr.Stderr) == 0 { + gitErr.err = ErrNotOnAnyBranch gitErr.Stderr = "not on any branch" return "", gitErr }