STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use strings.Builder for more efficient string concatenation

Browse source 
It minimizes memory copying.

Reference: https://golang.org/pkg/strings/#Builder
This commit is contained in:
XD-DENG 2020-10-19 20:51:51 +02:00
parent f1ea9102c4
commit 7e9f1c7147
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
pkg/cmd/pr/create/create.go
View file

@ -501,11 +501,11 @@ func computeDefaults(baseRef, headRef string) (shared.Defaults, error) {
} else {
out.Title = utils.Humanize(headRef)
body := ""
var body strings.Builder
for i := len(commits) - 1; i >= 0; i-- {
body += fmt.Sprintf("- %s\n", commits[i].Title)
fmt.Fprintf(&body, "- %s\n", commits[i].Title)
}
out.Body = body
out.Body = body.String()
}
return out, nil