From 800be370def4a0b1412215d153292e5af3cc49b4 Mon Sep 17 00:00:00 2001 From: Francisco Miamoto Date: Wed, 12 Aug 2020 09:18:43 -0300 Subject: [PATCH] propagate error from closure --- pkg/cmd/api/api.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/pkg/cmd/api/api.go b/pkg/cmd/api/api.go index 6342fbe03..dbc3d174a 100644 --- a/pkg/cmd/api/api.go +++ b/pkg/cmd/api/api.go @@ -300,8 +300,6 @@ func fillPlaceholders(value string, opts *ApiOptions) (string, error) { return value, err } - var branch string - filled := placeholderRE.ReplaceAllStringFunc(value, func(m string) string { switch m { case ":owner": @@ -309,7 +307,10 @@ func fillPlaceholders(value string, opts *ApiOptions) (string, error) { case ":repo": return baseRepo.RepoName() case ":branch": - branch, err = opts.Branch() + branch, e := opts.Branch() + if e != nil { + err = e + } return branch default: panic(fmt.Sprintf("invalid placeholder: %q", m))