From 8f5da9408af2111c08512461cffd0b838a2b4cd2 Mon Sep 17 00:00:00 2001 From: vilmibm Date: Mon, 8 Jun 2020 12:09:43 -0500 Subject: [PATCH 1/6] add docs about new triage rotation --- docs/triage.md | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 docs/triage.md diff --git a/docs/triage.md b/docs/triage.md new file mode 100644 index 000000000..cba288e45 --- /dev/null +++ b/docs/triage.md @@ -0,0 +1,61 @@ +# Triage role + +As we get more issues and pull requests opened on the GitHub CLI, we've decided on a weekly rotation +triage role. The initial expectation is that the person in the role for the week spends no more than +1-2 hours a day on this work; we can refine that as needed. + +# Incoming issues + +just imagine a flowchart + +- can this be closed outright? + - e.g. spam/junk + - close without comment +- do we not want to do it? + - e.g. have already discussed not wanting to do or duplicate issue + - comment acknowledging receipt + - close +- do we want to do it? + - e.g. bugs or things we have discussed before + - comment acknowledging it + - label appropriately + - add to project TODO column if appropriate, otherwise just leave it labeled +- is it intriguing but needs discussion? + - label design-needed if amanda is needed, ping + - ping engineers if eng needed + - ping billy if producty +- does it need more info? + - ask the user for that + - add user input label +- is it a user asking for help and you have all the info you need to help? + - try and help + +# Incoming PRs + +just imagine a flowchart + +- can it be closed outright? + - ie spam/junk +- do we not want to do it? + - ie have already discussed not wanting to do, duplicate issue + - comment acknowledging receipt + - close +- is it intriguing but needs discussion? + - request an issue + - close +- is it something we want to include? + - add `community` label + - add to `needs review` column + +# Weekly PR audit + +In the interest of not letting our open PR list get out of hand (20+ total PRs _or_ multiple PRs +over a few months old), try to audit open PRs each week with the goal of getting them merged and/or +closed. It's likely too much work to deal with every PR, but even getting a few closer to done is +helpful. + +For each PR, ask: + +- is this too stale? close with comment +- is this really close but author is absent? push commits to finish, request review +- is this waiting on triage? go through the PR triage flow From 47129f02b51c4c76deec634e3a5c3261c400fb5c Mon Sep 17 00:00:00 2001 From: Nate Smith Date: Tue, 9 Jun 2020 10:08:49 -0500 Subject: [PATCH 2/6] Update docs/triage.md Co-authored-by: Neha Batra --- docs/triage.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/triage.md b/docs/triage.md index cba288e45..d4efe45fa 100644 --- a/docs/triage.md +++ b/docs/triage.md @@ -21,7 +21,7 @@ just imagine a flowchart - label appropriately - add to project TODO column if appropriate, otherwise just leave it labeled - is it intriguing but needs discussion? - - label design-needed if amanda is needed, ping + - label `needs-design` if design input is needed, ping - ping engineers if eng needed - ping billy if producty - does it need more info? From 70035501e9deeba7c99ccda09e70912929a46582 Mon Sep 17 00:00:00 2001 From: Nate Smith Date: Tue, 9 Jun 2020 10:08:57 -0500 Subject: [PATCH 3/6] Update docs/triage.md Co-authored-by: Neha Batra --- docs/triage.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/triage.md b/docs/triage.md index d4efe45fa..4d0dffd04 100644 --- a/docs/triage.md +++ b/docs/triage.md @@ -26,7 +26,7 @@ just imagine a flowchart - ping billy if producty - does it need more info? - ask the user for that - - add user input label + - add `needs-user-input` label - is it a user asking for help and you have all the info you need to help? - try and help From 25b2573775c0020efb05dfa053875b68c4e7b8b5 Mon Sep 17 00:00:00 2001 From: vilmibm Date: Tue, 9 Jun 2020 10:30:25 -0500 Subject: [PATCH 4/6] mention needs-investigation --- docs/triage.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/triage.md b/docs/triage.md index 4d0dffd04..b1c66b048 100644 --- a/docs/triage.md +++ b/docs/triage.md @@ -22,9 +22,10 @@ just imagine a flowchart - add to project TODO column if appropriate, otherwise just leave it labeled - is it intriguing but needs discussion? - label `needs-design` if design input is needed, ping + - label `needs-investigation` if engineering research is required before action can be taken - ping engineers if eng needed - - ping billy if producty -- does it need more info? + - ping product if it's about future directions/roadamp/big changes +- does it need more info from the issue author? - ask the user for that - add `needs-user-input` label - is it a user asking for help and you have all the info you need to help? From 26f9e07145f3f2b9ea3c2f769342dc5ecb8752b3 Mon Sep 17 00:00:00 2001 From: Corey Johnson Date: Tue, 9 Jun 2020 14:21:10 -0700 Subject: [PATCH 5/6] Add label examples --- docs/triage.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/triage.md b/docs/triage.md index b1c66b048..e461c1a95 100644 --- a/docs/triage.md +++ b/docs/triage.md @@ -18,7 +18,7 @@ just imagine a flowchart - do we want to do it? - e.g. bugs or things we have discussed before - comment acknowledging it - - label appropriately + - label appropriately (examples include `enhancement` or `bug`) - add to project TODO column if appropriate, otherwise just leave it labeled - is it intriguing but needs discussion? - label `needs-design` if design input is needed, ping From c8dde91b68320db382a2b7bc16a42d7fa6391941 Mon Sep 17 00:00:00 2001 From: Corey Johnson Date: Tue, 9 Jun 2020 15:03:20 -0700 Subject: [PATCH 6/6] whitespace fixes --- docs/triage.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/triage.md b/docs/triage.md index e461c1a95..95e1bf852 100644 --- a/docs/triage.md +++ b/docs/triage.md @@ -15,7 +15,7 @@ just imagine a flowchart - e.g. have already discussed not wanting to do or duplicate issue - comment acknowledging receipt - close -- do we want to do it? +- do we want to do it? - e.g. bugs or things we have discussed before - comment acknowledging it - label appropriately (examples include `enhancement` or `bug`) @@ -50,7 +50,7 @@ just imagine a flowchart # Weekly PR audit -In the interest of not letting our open PR list get out of hand (20+ total PRs _or_ multiple PRs +In the interest of not letting our open PR list get out of hand (20+ total PRs _or_ multiple PRs over a few months old), try to audit open PRs each week with the goal of getting them merged and/or closed. It's likely too much work to deal with every PR, but even getting a few closer to done is helpful.