From 88ce5320f608ab39d11011d4a4cb1e836fb1739d Mon Sep 17 00:00:00 2001 From: Jessica Sestak Date: Tue, 25 May 2021 23:04:42 -0700 Subject: [PATCH] made branch and line flags, fixed path --- pkg/cmd/browse/browse.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go index 5aa405c5c..d0ea0f960 100644 --- a/pkg/cmd/browse/browse.go +++ b/pkg/cmd/browse/browse.go @@ -29,6 +29,8 @@ type BrowseOptions struct { ProjectsFlag bool WikiFlag bool SettingsFlag bool + BranchFlag bool + LineFlag bool } type exitCode int @@ -61,7 +63,7 @@ func NewCmdBrowse(f *cmdutil.Factory) *cobra.Command { Run: func(cmd *cobra.Command, args []string) { if len(args) > 1 { - + opts.AdditionalArg = args[1] } if len(args) > 0 { @@ -73,7 +75,9 @@ func NewCmdBrowse(f *cmdutil.Factory) *cobra.Command { cmd.Flags().BoolVarP(&opts.ProjectsFlag, "projects", "p", false, "Open projects tab in browser") cmd.Flags().BoolVarP(&opts.WikiFlag, "wiki", "w", false, "Opens the wiki in browser") - cmd.Flags().BoolVarP(&opts.SettingsFlag, "settings", "s", false, "Opens the settings in browse") + cmd.Flags().BoolVarP(&opts.SettingsFlag, "settings", "s", false, "Opens the settings in browser") + cmd.Flags().BoolVarP(&opts.BranchFlag, "branch", "b", false, "Opens a branch in the browser") + cmd.Flags().BoolVarP(&opts.LineFlag, "line", "l", false, "Opens up to a line in a file in the browser") return cmd } @@ -113,7 +117,7 @@ func openInBrowser(cmd *cobra.Command, opts *BrowseOptions) { } func addCombined(opts *BrowseOptions) string { - if isNumber(opts.AdditionalArg) { // if second arg is a number it should be a line number + if isNumber(opts.AdditionalArg) && opts.LineFlag { // if second arg is a number it should be a line number return "/" + opts.SelectorArg + "#L" + opts.AdditionalArg } return "/tree/" + opts.AdditionalArg + "/" + opts.SelectorArg