From 8d701dc13eb200242581c11f5852e855ee088014 Mon Sep 17 00:00:00 2001 From: ejahnGithub Date: Tue, 23 Sep 2025 11:12:19 -0400 Subject: [PATCH] update the test --- .../release/verify-asset/verify_asset_test.go | 37 ------------------- pkg/cmd/release/verify/verify_test.go | 36 ------------------ 2 files changed, 73 deletions(-) diff --git a/pkg/cmd/release/verify-asset/verify_asset_test.go b/pkg/cmd/release/verify-asset/verify_asset_test.go index 0da3cc6ab..732de9fd2 100644 --- a/pkg/cmd/release/verify-asset/verify_asset_test.go +++ b/pkg/cmd/release/verify-asset/verify_asset_test.go @@ -83,43 +83,6 @@ func TestNewCmdVerifyAsset_Args(t *testing.T) { } } -// Test that Initiator is set to "github" when fetching attestations -func Test_verifyAssetRun_InitiatorParam(t *testing.T) { - ios, _, _, _ := iostreams.Test() - tagName := "v6" - - fakeHTTP := &httpmock.Registry{} - defer fakeHTTP.Verify(t) - fakeSHA := "1234567890abcdef1234567890abcdef12345678" - shared.StubFetchRefSHA(t, fakeHTTP, "owner", "repo", tagName, fakeSHA) - - baseRepo, err := ghrepo.FromFullName("owner/repo") - require.NoError(t, err) - - // Capture FetchParams passed to GetByDigest - var gotParams api.FetchParams - mockClient := &api.MockClient{ - OnGetByDigest: func(params api.FetchParams) ([]*api.Attestation, error) { - gotParams = params - return []*api.Attestation{}, nil - }, - } - - cfg := &VerifyAssetConfig{ - Opts: &VerifyAssetOptions{ - AssetFilePath: test.NormalizeRelativePath("../../attestation/test/data/github_release_artifact.zip"), - TagName: tagName, - BaseRepo: baseRepo, - }, - IO: ios, - HttpClient: &http.Client{Transport: fakeHTTP}, - AttClient: mockClient, - AttVerifier: nil, - } - _ = verifyAssetRun(cfg) - assert.Equal(t, "github", gotParams.Initiator) -} - func Test_verifyAssetRun_Success(t *testing.T) { ios, _, _, _ := iostreams.Test() tagName := "v6" diff --git a/pkg/cmd/release/verify/verify_test.go b/pkg/cmd/release/verify/verify_test.go index 84b5fec08..40009fc7d 100644 --- a/pkg/cmd/release/verify/verify_test.go +++ b/pkg/cmd/release/verify/verify_test.go @@ -66,42 +66,6 @@ func TestNewCmdVerify_Args(t *testing.T) { } } -// Test that Initiator is set to "github" when fetching attestations in verifyRun -func Test_verifyRun_InitiatorParam(t *testing.T) { - ios, _, _, _ := iostreams.Test() - tagName := "v1.2.3" - - fakeHTTP := &httpmock.Registry{} - defer fakeHTTP.Verify(t) - fakeSHA := "1234567890abcdef1234567890abcdef12345678" - shared.StubFetchRefSHA(t, fakeHTTP, "owner", "repo", tagName, fakeSHA) - - baseRepo, err := ghrepo.FromFullName("owner/repo") - require.NoError(t, err) - - // Capture FetchParams passed to GetByDigest - var gotParams api.FetchParams - mockClient := &api.MockClient{ - OnGetByDigest: func(params api.FetchParams) ([]*api.Attestation, error) { - gotParams = params - return []*api.Attestation{}, nil - }, - } - - cfg := &VerifyConfig{ - Opts: &VerifyOptions{ - TagName: tagName, - BaseRepo: baseRepo, - }, - IO: ios, - HttpClient: &http.Client{Transport: fakeHTTP}, - AttClient: mockClient, - } - // Execute verifyRun, ignoring error since mockClient returns empty slice - _ = verifyRun(cfg) - assert.Equal(t, "github", gotParams.Initiator) -} - func Test_verifyRun_Success(t *testing.T) { ios, _, _, _ := iostreams.Test() tagName := "v6"