From 8e64c149e155c1b7d51524e22b27e2399d2f5496 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mislav=20Marohni=C4=87?= Date: Thu, 13 Jan 2022 11:58:58 +0100 Subject: [PATCH] Return errors in ask stubber instead of panicking --- pkg/prompt/stubber.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/prompt/stubber.go b/pkg/prompt/stubber.go index 482381161..3159540f3 100644 --- a/pkg/prompt/stubber.go +++ b/pkg/prompt/stubber.go @@ -41,7 +41,7 @@ func InitAskStubber() (*AskStubber, func()) { message = pt.Message defaultValue = pt.Default default: - panic(fmt.Sprintf("prompt type %T is not supported by the stubber", pt)) + return fmt.Errorf("prompt type %T is not supported by the stubber", pt) } var stub *QuestionStub @@ -53,12 +53,12 @@ func InitAskStubber() (*AskStubber, func()) { } } if stub == nil { - panic(fmt.Sprintf("no prompt stub for %q", message)) + return fmt.Errorf("no prompt stub for %q", message) } if len(stub.options) > 0 { if err := compareOptions(stub.options, options); err != nil { - panic(fmt.Sprintf("options mismatch for %q: %v", message, err)) + return fmt.Errorf("stubbed options mismatch for %q: %v", message, err) } } @@ -73,7 +73,7 @@ func InitAskStubber() (*AskStubber, func()) { } } if foundIndex < 0 { - panic(fmt.Sprintf("answer %q not found in options for %q: %v", stringValue, message, options)) + return fmt.Errorf("answer %q not found in options for %q: %v", stringValue, message, options) } userValue = core.OptionAnswer{ Value: stringValue,