From 8ff70e6e7ad6b2df3fd2a6988ed287189dd60ce2 Mon Sep 17 00:00:00 2001 From: William Martin Date: Fri, 1 May 2026 17:23:01 +0200 Subject: [PATCH] Remove numberFieldOnly API shortcut Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --- pkg/cmd/pr/shared/finder.go | 6 ------ pkg/cmd/pr/shared/finder_test.go | 19 ------------------- 2 files changed, 25 deletions(-) diff --git a/pkg/cmd/pr/shared/finder.go b/pkg/cmd/pr/shared/finder.go index 80f1e707d..ade906534 100644 --- a/pkg/cmd/pr/shared/finder.go +++ b/pkg/cmd/pr/shared/finder.go @@ -207,7 +207,6 @@ func (f *finder) Find(opts FindOptions) (*api.PullRequest, ghrepo.Interface, err fields := set.NewStringSet() fields.AddValues(opts.Fields) - numberFieldOnly := fields.Len() == 1 && fields.Contains("number") fields.AddValues([]string{"id", "number"}) // for additional preload queries below if fields.Contains("isInMergeQueue") || fields.Contains("isMergeQueueEnabled") { @@ -248,11 +247,6 @@ func (f *finder) Find(opts FindOptions) (*api.PullRequest, ghrepo.Interface, err var pr *api.PullRequest if f.prNumber > 0 { - // If we have a PR number, let's look it up - if numberFieldOnly { - // avoid hitting the API if we already have all the information - return &api.PullRequest{Number: f.prNumber}, f.baseRefRepo, nil - } pr, err = findByNumber(httpClient, f.baseRefRepo, f.prNumber, fields.ToSlice()) if err != nil { return pr, f.baseRefRepo, err diff --git a/pkg/cmd/pr/shared/finder_test.go b/pkg/cmd/pr/shared/finder_test.go index af3437060..8177fe144 100644 --- a/pkg/cmd/pr/shared/finder_test.go +++ b/pkg/cmd/pr/shared/finder_test.go @@ -326,25 +326,6 @@ func TestFind(t *testing.T) { }, wantErr: true, }, - { - name: "number only", - args: args{ - selector: "13", - fields: []string{"number"}, - baseRepoFn: stubBaseRepoFn(ghrepo.New("ORIGINOWNER", "REPO"), nil), - branchFn: func() (string, error) { - return "blueberries", nil - }, - gitConfigClient: stubGitConfigClient{ - readBranchConfigFn: stubBranchConfig(git.BranchConfig{}, nil), - pushDefaultFn: stubPushDefault(git.PushDefaultSimple, nil), - remotePushDefaultFn: stubRemotePushDefault("", nil), - }, - }, - httpStub: nil, - wantPR: 13, - wantRepo: "https://github.com/ORIGINOWNER/REPO", - }, { name: "pr number zero", args: args{