From 9051da39fc559ee73ffb1d870863c9100fd5c9f6 Mon Sep 17 00:00:00 2001 From: Meredith Lancaster Date: Mon, 6 Jan 2025 10:19:47 -0700 Subject: [PATCH] provide additional logging and fallback Signed-off-by: Meredith Lancaster --- pkg/cmd/attestation/api/client.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/pkg/cmd/attestation/api/client.go b/pkg/cmd/attestation/api/client.go index 2519aa9e4..51b67d33d 100644 --- a/pkg/cmd/attestation/api/client.go +++ b/pkg/cmd/attestation/api/client.go @@ -26,11 +26,13 @@ const ( // Allow injecting backoff interval in tests. var getAttestationRetryInterval = time.Millisecond * 200 +// githubApiClient makes REST calls to the GitHub API type githubApiClient interface { REST(hostname, method, p string, body io.Reader, data interface{}) error RESTWithNext(hostname, method, p string, body io.Reader, data interface{}) (string, error) } +// httpClient makes HTTP calls to all non-GitHub API endpoints type httpClient interface { Get(url string) (*http.Response, error) } @@ -180,7 +182,8 @@ func (c *LiveClient) fetchBundlesByURL(attestations []*Attestation) ([]*Attestat func (c *LiveClient) fetchBundleByURL(a *Attestation) (*bundle.Bundle, error) { if a.BundleURL == "" { - return nil, fmt.Errorf("bundle URL is empty") + c.logger.VerbosePrintf("Bundle URL is empty. Falling back to bundle field\n\n") + return a.Bundle, nil } c.logger.VerbosePrintf("Fetching attestation bundle\n\n")