From f7ef503051ff7a3845738c4846d73a49f3c62f76 Mon Sep 17 00:00:00 2001 From: Callum Macrae Date: Fri, 25 Mar 2022 15:07:47 +0000 Subject: [PATCH] fix: respect `GH_FORCE_TTY` when running `gh pr view` `GH_FORCE_TTY` only affects stdout, not stderr, so this check was failing and the flag was being ignored. I also checked for similar problem in other files but everything else seemed stderr or stdin related. closes #5354 --- pkg/cmd/pr/view/view.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/pr/view/view.go b/pkg/cmd/pr/view/view.go index 67124b195..019ba53b5 100644 --- a/pkg/cmd/pr/view/view.go +++ b/pkg/cmd/pr/view/view.go @@ -98,7 +98,7 @@ func viewRun(opts *ViewOptions) error { return err } - connectedToTerminal := opts.IO.IsStdoutTTY() && opts.IO.IsStderrTTY() + connectedToTerminal := opts.IO.IsStdoutTTY() if opts.BrowserMode { openURL := pr.URL