From 5af1cccb73310136e0de4d1055ee55e9db29cb7a Mon Sep 17 00:00:00 2001 From: Issy Long Date: Wed, 18 Aug 2021 18:05:59 +0100 Subject: [PATCH 1/2] cmd/ghcs/delete: When matching repos to delete, standardize casing - It was possible to delete Codespaces for repo `SomePerson/foo` but not `someperson/foo`, despite the fact that the GitHub APIs don't actually care about casing - `SomePerson` and `someperson` is the same account. - This fixes that by lowercasing both the user-provided repo name, and the repository that is attached to the Codespace for a match. - Fixes #76. --- cmd/ghcs/delete.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cmd/ghcs/delete.go b/cmd/ghcs/delete.go index d79bcc448..e789ba1ba 100644 --- a/cmd/ghcs/delete.go +++ b/cmd/ghcs/delete.go @@ -4,6 +4,7 @@ import ( "context" "fmt" "os" + "strings" "github.com/github/ghcs/api" "github.com/github/ghcs/cmd/ghcs/output" @@ -124,7 +125,7 @@ func DeleteByRepo(repo string) error { var deleted bool for _, c := range codespaces { - if c.RepositoryNWO != repo { + if strings.ToLower(c.RepositoryNWO) != strings.ToLower(repo) { continue } deleted = true From 28a3644a079169b78aa0a8149e9eed15ef98445d Mon Sep 17 00:00:00 2001 From: Issy Long Date: Wed, 18 Aug 2021 18:15:15 +0100 Subject: [PATCH 2/2] cmd/ghcs/delete: I learnt about `strings.EqualFold` - thanks, linter! --- cmd/ghcs/delete.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/ghcs/delete.go b/cmd/ghcs/delete.go index e789ba1ba..c357171d1 100644 --- a/cmd/ghcs/delete.go +++ b/cmd/ghcs/delete.go @@ -125,7 +125,7 @@ func DeleteByRepo(repo string) error { var deleted bool for _, c := range codespaces { - if strings.ToLower(c.RepositoryNWO) != strings.ToLower(repo) { + if !strings.EqualFold(c.RepositoryNWO, repo) { continue } deleted = true