From 97aa0b2f7daf7abaf445970aa16e89b1532a42c7 Mon Sep 17 00:00:00 2001 From: Cristian Dominguez Date: Wed, 4 Nov 2020 12:10:35 -0300 Subject: [PATCH] Warn when passing git flags without repository arg --- pkg/cmd/repo/fork/fork.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/repo/fork/fork.go b/pkg/cmd/repo/fork/fork.go index 0eb5569c8..ce99f4a6b 100644 --- a/pkg/cmd/repo/fork/fork.go +++ b/pkg/cmd/repo/fork/fork.go @@ -50,8 +50,13 @@ func NewCmdFork(f *cmdutil.Factory, runF func(*ForkOptions) error) *cobra.Comman } cmd := &cobra.Command{ - Use: "fork [] [-- ...]", - Args: cobra.MaximumNArgs(2), + Use: "fork [] [-- ...]", + Args: func(cmd *cobra.Command, args []string) error { + if cmd.ArgsLenAtDash() == 0 && len(args[1:]) > 0 { + return cmdutil.FlagError{Err: fmt.Errorf("repository argument required when passing 'git clone' flags")} + } + return nil + }, Short: "Create a fork of a repository", Long: `Create a fork of a repository.