From 97eb8a194e465a0aeda3eba0af72210998dac93c Mon Sep 17 00:00:00 2001 From: Andy Feller Date: Fri, 10 Jan 2025 14:29:55 -0500 Subject: [PATCH] Simplifying cleanExtensionUpdateDir logic This function was doing some unnecessary heavy lifting detecting if the directory being deleted actually existed when `os.RemoveAll()` would handle directories that exist or not. --- pkg/cmd/extension/manager.go | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/pkg/cmd/extension/manager.go b/pkg/cmd/extension/manager.go index 5881269cf..e754306d8 100644 --- a/pkg/cmd/extension/manager.go +++ b/pkg/cmd/extension/manager.go @@ -851,14 +851,7 @@ func codesignBinary(binPath string) error { // cleanExtensionUpdateDir deletes extension state directory to avoid problems reinstalling extensions. func (m *Manager) cleanExtensionUpdateDir(name string) error { - updatePath := m.UpdateDir(name) - if _, err := os.Stat(updatePath); err != nil { - if os.IsNotExist(err) { - return nil - } - return fmt.Errorf("failed to check previous extension update state: %w", err) - } - if err := os.RemoveAll(updatePath); err != nil { + if err := os.RemoveAll(m.UpdateDir(name)); err != nil { return fmt.Errorf("failed to remove previous extension update state: %w", err) } return nil