From 8f5806d61ffb6508a65a7d4630e125ce6da31892 Mon Sep 17 00:00:00 2001 From: Sam Coe Date: Tue, 5 Oct 2021 09:10:49 -0700 Subject: [PATCH 1/2] Set io when initializing extension manager --- pkg/cmd/extension/manager.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/cmd/extension/manager.go b/pkg/cmd/extension/manager.go index f9ab502d1..f238db10b 100644 --- a/pkg/cmd/extension/manager.go +++ b/pkg/cmd/extension/manager.go @@ -46,6 +46,7 @@ func NewManager(io *iostreams.IOStreams) *Manager { platform: func() string { return fmt.Sprintf("%s-%s", runtime.GOOS, runtime.GOARCH) }, + io: io, } } From 400749d560caf6ed7f8cc9e9a11923ea32bbd8fa Mon Sep 17 00:00:00 2001 From: Jose Garcia Date: Thu, 7 Oct 2021 11:01:24 -0400 Subject: [PATCH 2/2] Fix regression returning nil codespace --- internal/codespaces/api/api.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/codespaces/api/api.go b/internal/codespaces/api/api.go index 6fd9e4d18..531b2b3f8 100644 --- a/internal/codespaces/api/api.go +++ b/internal/codespaces/api/api.go @@ -425,7 +425,7 @@ type CreateCodespaceParams struct { func (a *API) CreateCodespace(ctx context.Context, params *CreateCodespaceParams) (*Codespace, error) { codespace, err := a.startCreate(ctx, params.RepositoryID, params.Machine, params.Branch, params.Location) if err != errProvisioningInProgress { - return nil, err + return codespace, err } // errProvisioningInProgress indicates that codespace creation did not complete