From 9f451d9eef69aa6488d4514a10c664811ef08c08 Mon Sep 17 00:00:00 2001 From: nate smith Date: Thu, 29 Apr 2021 16:06:26 -0500 Subject: [PATCH] review feedback --- cmd/gh/main.go | 2 +- pkg/cmd/root/help_topic.go | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cmd/gh/main.go b/cmd/gh/main.go index 57af7b966..b9dc52858 100644 --- a/cmd/gh/main.go +++ b/cmd/gh/main.go @@ -178,7 +178,7 @@ func mainRun() exitCode { if strings.Contains(err.Error(), "Incorrect function") { fmt.Fprintln(stderr, "You appear to be running in MinTTY without pseudo terminal support.") - fmt.Fprintln(stderr, "To learn about workarounds for this error, gh help mintty") + fmt.Fprintln(stderr, "To learn about workarounds for this error, run: gh help mintty") return exitError } diff --git a/pkg/cmd/root/help_topic.go b/pkg/cmd/root/help_topic.go index 06cc04517..968b8a617 100644 --- a/pkg/cmd/root/help_topic.go +++ b/pkg/cmd/root/help_topic.go @@ -15,11 +15,11 @@ var HelpTopics = map[string]map[string]string{ There are a few workarounds to make gh work with MinTTY: - - Reinstall Git for Windows. - Be sure to check the box "Enable experimental support for pseudo consoles". + - Reinstall Git for Windows, checking "Enable experimental support for pseudo consoles". - - Use a different terminal emulator with Git for Windows like Windows Terminal or cmd.exe. - Try running "C:\Program Files\Git\bin\bash.exe" in one of those other terminal emulators. + - Use a different terminal emulator with Git for Windows like Windows Terminal. + You can run "C:\Program Files\Git\bin\bash.exe" from any terminal emulator to continue + using all of the tooling in Git For Windows without MinTTY. - Prefix invocations of gh with winpty, eg: "winpty gh auth login". NOTE: this can lead to some UI bugs.