Merge pull request #10216 from nobe4/improve-padded-display

fix: padded display

pkg/cmd/extension/manager.go

@@ -11,6 +11,7 @@ import (
 	"path"
 	"path/filepath"
 	"runtime"
+	"slices"
 	"strings"
 	"sync"
 
@@ -469,18 +470,14 @@ func (m *Manager) Upgrade(name string, force bool) error {
 }
 
 func (m *Manager) upgradeExtensions(exts []*Extension, force bool) error {
-	var longestExtName = 0
+	var longestExt = slices.MaxFunc(exts, func(a, b *Extension) int {
-	for _, ext := range exts {
+		return len(a.Name()) - len(b.Name())
-		l := len(ext.Name())
+	})
-		if len(ext.Name()) > longestExtName {
+	var longestExtName = len(longestExt.Name())
-			longestExtName = l
-		}
-	}
-	format := fmt.Sprintf("[%%%ds]: ", longestExtName)
 
 	var failed bool
 	for _, f := range exts {
-		fmt.Fprintf(m.io.Out, format, f.Name())
+		fmt.Fprintf(m.io.Out, "[%*s]: ", longestExtName, f.Name())
 		currentVersion := displayExtensionVersion(f, f.CurrentVersion())
 		err := m.upgradeExtension(f, force)
 		if err != nil {