From 7ade90089d51ed9b2690fad75356a81b786d2f21 Mon Sep 17 00:00:00 2001 From: JP Ungaretti Date: Fri, 4 Nov 2022 20:12:19 +0000 Subject: [PATCH 1/4] Add docs for gRPC --- internal/codespaces/grpc/generate.md | 16 +++ internal/codespaces/grpc/generate.sh | 27 ++++ .../jupyter/JupyterServerHostService.v1.pb.go | 122 +++++++++--------- .../JupyterServerHostService.v1_grpc.pb.go | 6 +- 4 files changed, 107 insertions(+), 64 deletions(-) create mode 100644 internal/codespaces/grpc/generate.md create mode 100755 internal/codespaces/grpc/generate.sh diff --git a/internal/codespaces/grpc/generate.md b/internal/codespaces/grpc/generate.md new file mode 100644 index 000000000..7cc18430b --- /dev/null +++ b/internal/codespaces/grpc/generate.md @@ -0,0 +1,16 @@ +# Protocol Buffers for Codespaces + +Instructions for generating and adding gRPC protocol buffers. + +## Generate Protocol Buffers: + +1. [Download `protoc`](https://grpc.io/docs/protoc-installation/) +2. [Download protocol compiler plugins for Go](https://grpc.io/docs/languages/go/quickstart/) +3. Run `./generate.sh` + +## Add New Protocol Buffers + +1. Download a `.proto` contract from the service repo +2. Create a new directory and copy the `.proto` to it +3. Update `generate.sh` to include the include the new `.proto` +4. Follow the instructions to [Generate Protocol Buffers](#generate-protocol-buffers) diff --git a/internal/codespaces/grpc/generate.sh b/internal/codespaces/grpc/generate.sh new file mode 100755 index 000000000..e88dc156f --- /dev/null +++ b/internal/codespaces/grpc/generate.sh @@ -0,0 +1,27 @@ +#!/bin/bash + +set -e + +if ! protoc --version; then + echo 'ERROR: protoc is not on your PATH' + exit 1 +fi +if ! protoc-gen-go --version; then + echo 'ERROR: protoc-gen-go is not on your PATH' + exit 1 +fi +if ! protoc-gen-go-grpc --version; then + echo 'ERROR: protoc-gen-go-grpc is not on your PATH' +fi + +function generate { + local contract="$1" + + protoc --go_out=. --go_opt=paths=source_relative --go-grpc_out=. --go-grpc_opt=paths=source_relative "$contract" + echo "Generated protocol buffers for $contract" +} + +generate codespace/CodespaceHostService.v1.proto +generate jupyter/JupyterServerHostService.v1.proto + +echo 'Done!' diff --git a/internal/codespaces/grpc/jupyter/JupyterServerHostService.v1.pb.go b/internal/codespaces/grpc/jupyter/JupyterServerHostService.v1.pb.go index c48f3d0cf..88b33a50d 100644 --- a/internal/codespaces/grpc/jupyter/JupyterServerHostService.v1.pb.go +++ b/internal/codespaces/grpc/jupyter/JupyterServerHostService.v1.pb.go @@ -1,8 +1,8 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // versions: -// protoc-gen-go v1.28.0 -// protoc v3.21.3 -// source: JupyterServerHostService.v1.proto +// protoc-gen-go v1.28.1 +// protoc v3.12.4 +// source: jupyter/JupyterServerHostService.v1.proto package jupyter @@ -29,7 +29,7 @@ type GetRunningServerRequest struct { func (x *GetRunningServerRequest) Reset() { *x = GetRunningServerRequest{} if protoimpl.UnsafeEnabled { - mi := &file_JupyterServerHostService_v1_proto_msgTypes[0] + mi := &file_jupyter_JupyterServerHostService_v1_proto_msgTypes[0] ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x)) ms.StoreMessageInfo(mi) } @@ -42,7 +42,7 @@ func (x *GetRunningServerRequest) String() string { func (*GetRunningServerRequest) ProtoMessage() {} func (x *GetRunningServerRequest) ProtoReflect() protoreflect.Message { - mi := &file_JupyterServerHostService_v1_proto_msgTypes[0] + mi := &file_jupyter_JupyterServerHostService_v1_proto_msgTypes[0] if protoimpl.UnsafeEnabled && x != nil { ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x)) if ms.LoadMessageInfo() == nil { @@ -55,7 +55,7 @@ func (x *GetRunningServerRequest) ProtoReflect() protoreflect.Message { // Deprecated: Use GetRunningServerRequest.ProtoReflect.Descriptor instead. func (*GetRunningServerRequest) Descriptor() ([]byte, []int) { - return file_JupyterServerHostService_v1_proto_rawDescGZIP(), []int{0} + return file_jupyter_JupyterServerHostService_v1_proto_rawDescGZIP(), []int{0} } type GetRunningServerResponse struct { @@ -72,7 +72,7 @@ type GetRunningServerResponse struct { func (x *GetRunningServerResponse) Reset() { *x = GetRunningServerResponse{} if protoimpl.UnsafeEnabled { - mi := &file_JupyterServerHostService_v1_proto_msgTypes[1] + mi := &file_jupyter_JupyterServerHostService_v1_proto_msgTypes[1] ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x)) ms.StoreMessageInfo(mi) } @@ -85,7 +85,7 @@ func (x *GetRunningServerResponse) String() string { func (*GetRunningServerResponse) ProtoMessage() {} func (x *GetRunningServerResponse) ProtoReflect() protoreflect.Message { - mi := &file_JupyterServerHostService_v1_proto_msgTypes[1] + mi := &file_jupyter_JupyterServerHostService_v1_proto_msgTypes[1] if protoimpl.UnsafeEnabled && x != nil { ms := protoimpl.X.MessageStateOf(protoimpl.Pointer(x)) if ms.LoadMessageInfo() == nil { @@ -98,7 +98,7 @@ func (x *GetRunningServerResponse) ProtoReflect() protoreflect.Message { // Deprecated: Use GetRunningServerResponse.ProtoReflect.Descriptor instead. func (*GetRunningServerResponse) Descriptor() ([]byte, []int) { - return file_JupyterServerHostService_v1_proto_rawDescGZIP(), []int{1} + return file_jupyter_JupyterServerHostService_v1_proto_rawDescGZIP(), []int{1} } func (x *GetRunningServerResponse) GetResult() bool { @@ -129,57 +129,57 @@ func (x *GetRunningServerResponse) GetServerUrl() string { return "" } -var File_JupyterServerHostService_v1_proto protoreflect.FileDescriptor +var File_jupyter_JupyterServerHostService_v1_proto protoreflect.FileDescriptor -var file_JupyterServerHostService_v1_proto_rawDesc = []byte{ - 0x0a, 0x21, 0x4a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x48, - 0x6f, 0x73, 0x74, 0x53, 0x65, 0x72, 0x76, 0x69, 0x63, 0x65, 0x2e, 0x76, 0x31, 0x2e, 0x70, 0x72, - 0x6f, 0x74, 0x6f, 0x12, 0x2b, 0x43, 0x6f, 0x64, 0x65, 0x73, 0x70, 0x61, 0x63, 0x65, 0x73, 0x2e, - 0x47, 0x72, 0x70, 0x63, 0x2e, 0x4a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, 0x53, 0x65, 0x72, 0x76, - 0x65, 0x72, 0x48, 0x6f, 0x73, 0x74, 0x53, 0x65, 0x72, 0x76, 0x69, 0x63, 0x65, 0x2e, 0x76, 0x31, - 0x22, 0x19, 0x0a, 0x17, 0x47, 0x65, 0x74, 0x52, 0x75, 0x6e, 0x6e, 0x69, 0x6e, 0x67, 0x53, 0x65, - 0x72, 0x76, 0x65, 0x72, 0x52, 0x65, 0x71, 0x75, 0x65, 0x73, 0x74, 0x22, 0x7e, 0x0a, 0x18, 0x47, - 0x65, 0x74, 0x52, 0x75, 0x6e, 0x6e, 0x69, 0x6e, 0x67, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x52, - 0x65, 0x73, 0x70, 0x6f, 0x6e, 0x73, 0x65, 0x12, 0x16, 0x0a, 0x06, 0x52, 0x65, 0x73, 0x75, 0x6c, - 0x74, 0x18, 0x01, 0x20, 0x01, 0x28, 0x08, 0x52, 0x06, 0x52, 0x65, 0x73, 0x75, 0x6c, 0x74, 0x12, - 0x18, 0x0a, 0x07, 0x4d, 0x65, 0x73, 0x73, 0x61, 0x67, 0x65, 0x18, 0x02, 0x20, 0x01, 0x28, 0x09, - 0x52, 0x07, 0x4d, 0x65, 0x73, 0x73, 0x61, 0x67, 0x65, 0x12, 0x12, 0x0a, 0x04, 0x50, 0x6f, 0x72, - 0x74, 0x18, 0x03, 0x20, 0x01, 0x28, 0x09, 0x52, 0x04, 0x50, 0x6f, 0x72, 0x74, 0x12, 0x1c, 0x0a, - 0x09, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x55, 0x72, 0x6c, 0x18, 0x04, 0x20, 0x01, 0x28, 0x09, - 0x52, 0x09, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x55, 0x72, 0x6c, 0x32, 0xb5, 0x01, 0x0a, 0x11, - 0x4a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x48, 0x6f, 0x73, - 0x74, 0x12, 0x9f, 0x01, 0x0a, 0x10, 0x47, 0x65, 0x74, 0x52, 0x75, 0x6e, 0x6e, 0x69, 0x6e, 0x67, - 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x12, 0x44, 0x2e, 0x43, 0x6f, 0x64, 0x65, 0x73, 0x70, 0x61, - 0x63, 0x65, 0x73, 0x2e, 0x47, 0x72, 0x70, 0x63, 0x2e, 0x4a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, - 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x48, 0x6f, 0x73, 0x74, 0x53, 0x65, 0x72, 0x76, 0x69, 0x63, - 0x65, 0x2e, 0x76, 0x31, 0x2e, 0x47, 0x65, 0x74, 0x52, 0x75, 0x6e, 0x6e, 0x69, 0x6e, 0x67, 0x53, - 0x65, 0x72, 0x76, 0x65, 0x72, 0x52, 0x65, 0x71, 0x75, 0x65, 0x73, 0x74, 0x1a, 0x45, 0x2e, 0x43, - 0x6f, 0x64, 0x65, 0x73, 0x70, 0x61, 0x63, 0x65, 0x73, 0x2e, 0x47, 0x72, 0x70, 0x63, 0x2e, 0x4a, - 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x48, 0x6f, 0x73, 0x74, - 0x53, 0x65, 0x72, 0x76, 0x69, 0x63, 0x65, 0x2e, 0x76, 0x31, 0x2e, 0x47, 0x65, 0x74, 0x52, 0x75, - 0x6e, 0x6e, 0x69, 0x6e, 0x67, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x52, 0x65, 0x73, 0x70, 0x6f, - 0x6e, 0x73, 0x65, 0x42, 0x0b, 0x5a, 0x09, 0x2e, 0x2f, 0x6a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, - 0x62, 0x06, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x33, +var file_jupyter_JupyterServerHostService_v1_proto_rawDesc = []byte{ + 0x0a, 0x29, 0x6a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, 0x2f, 0x4a, 0x75, 0x70, 0x79, 0x74, 0x65, + 0x72, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x48, 0x6f, 0x73, 0x74, 0x53, 0x65, 0x72, 0x76, 0x69, + 0x63, 0x65, 0x2e, 0x76, 0x31, 0x2e, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x12, 0x2b, 0x43, 0x6f, 0x64, + 0x65, 0x73, 0x70, 0x61, 0x63, 0x65, 0x73, 0x2e, 0x47, 0x72, 0x70, 0x63, 0x2e, 0x4a, 0x75, 0x70, + 0x79, 0x74, 0x65, 0x72, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x48, 0x6f, 0x73, 0x74, 0x53, 0x65, + 0x72, 0x76, 0x69, 0x63, 0x65, 0x2e, 0x76, 0x31, 0x22, 0x19, 0x0a, 0x17, 0x47, 0x65, 0x74, 0x52, + 0x75, 0x6e, 0x6e, 0x69, 0x6e, 0x67, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x52, 0x65, 0x71, 0x75, + 0x65, 0x73, 0x74, 0x22, 0x7e, 0x0a, 0x18, 0x47, 0x65, 0x74, 0x52, 0x75, 0x6e, 0x6e, 0x69, 0x6e, + 0x67, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x52, 0x65, 0x73, 0x70, 0x6f, 0x6e, 0x73, 0x65, 0x12, + 0x16, 0x0a, 0x06, 0x52, 0x65, 0x73, 0x75, 0x6c, 0x74, 0x18, 0x01, 0x20, 0x01, 0x28, 0x08, 0x52, + 0x06, 0x52, 0x65, 0x73, 0x75, 0x6c, 0x74, 0x12, 0x18, 0x0a, 0x07, 0x4d, 0x65, 0x73, 0x73, 0x61, + 0x67, 0x65, 0x18, 0x02, 0x20, 0x01, 0x28, 0x09, 0x52, 0x07, 0x4d, 0x65, 0x73, 0x73, 0x61, 0x67, + 0x65, 0x12, 0x12, 0x0a, 0x04, 0x50, 0x6f, 0x72, 0x74, 0x18, 0x03, 0x20, 0x01, 0x28, 0x09, 0x52, + 0x04, 0x50, 0x6f, 0x72, 0x74, 0x12, 0x1c, 0x0a, 0x09, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x55, + 0x72, 0x6c, 0x18, 0x04, 0x20, 0x01, 0x28, 0x09, 0x52, 0x09, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, + 0x55, 0x72, 0x6c, 0x32, 0xb5, 0x01, 0x0a, 0x11, 0x4a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, 0x53, + 0x65, 0x72, 0x76, 0x65, 0x72, 0x48, 0x6f, 0x73, 0x74, 0x12, 0x9f, 0x01, 0x0a, 0x10, 0x47, 0x65, + 0x74, 0x52, 0x75, 0x6e, 0x6e, 0x69, 0x6e, 0x67, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x12, 0x44, + 0x2e, 0x43, 0x6f, 0x64, 0x65, 0x73, 0x70, 0x61, 0x63, 0x65, 0x73, 0x2e, 0x47, 0x72, 0x70, 0x63, + 0x2e, 0x4a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x48, 0x6f, + 0x73, 0x74, 0x53, 0x65, 0x72, 0x76, 0x69, 0x63, 0x65, 0x2e, 0x76, 0x31, 0x2e, 0x47, 0x65, 0x74, + 0x52, 0x75, 0x6e, 0x6e, 0x69, 0x6e, 0x67, 0x53, 0x65, 0x72, 0x76, 0x65, 0x72, 0x52, 0x65, 0x71, + 0x75, 0x65, 0x73, 0x74, 0x1a, 0x45, 0x2e, 0x43, 0x6f, 0x64, 0x65, 0x73, 0x70, 0x61, 0x63, 0x65, + 0x73, 0x2e, 0x47, 0x72, 0x70, 0x63, 0x2e, 0x4a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, 0x53, 0x65, + 0x72, 0x76, 0x65, 0x72, 0x48, 0x6f, 0x73, 0x74, 0x53, 0x65, 0x72, 0x76, 0x69, 0x63, 0x65, 0x2e, + 0x76, 0x31, 0x2e, 0x47, 0x65, 0x74, 0x52, 0x75, 0x6e, 0x6e, 0x69, 0x6e, 0x67, 0x53, 0x65, 0x72, + 0x76, 0x65, 0x72, 0x52, 0x65, 0x73, 0x70, 0x6f, 0x6e, 0x73, 0x65, 0x42, 0x0b, 0x5a, 0x09, 0x2e, + 0x2f, 0x6a, 0x75, 0x70, 0x79, 0x74, 0x65, 0x72, 0x62, 0x06, 0x70, 0x72, 0x6f, 0x74, 0x6f, 0x33, } var ( - file_JupyterServerHostService_v1_proto_rawDescOnce sync.Once - file_JupyterServerHostService_v1_proto_rawDescData = file_JupyterServerHostService_v1_proto_rawDesc + file_jupyter_JupyterServerHostService_v1_proto_rawDescOnce sync.Once + file_jupyter_JupyterServerHostService_v1_proto_rawDescData = file_jupyter_JupyterServerHostService_v1_proto_rawDesc ) -func file_JupyterServerHostService_v1_proto_rawDescGZIP() []byte { - file_JupyterServerHostService_v1_proto_rawDescOnce.Do(func() { - file_JupyterServerHostService_v1_proto_rawDescData = protoimpl.X.CompressGZIP(file_JupyterServerHostService_v1_proto_rawDescData) +func file_jupyter_JupyterServerHostService_v1_proto_rawDescGZIP() []byte { + file_jupyter_JupyterServerHostService_v1_proto_rawDescOnce.Do(func() { + file_jupyter_JupyterServerHostService_v1_proto_rawDescData = protoimpl.X.CompressGZIP(file_jupyter_JupyterServerHostService_v1_proto_rawDescData) }) - return file_JupyterServerHostService_v1_proto_rawDescData + return file_jupyter_JupyterServerHostService_v1_proto_rawDescData } -var file_JupyterServerHostService_v1_proto_msgTypes = make([]protoimpl.MessageInfo, 2) -var file_JupyterServerHostService_v1_proto_goTypes = []interface{}{ +var file_jupyter_JupyterServerHostService_v1_proto_msgTypes = make([]protoimpl.MessageInfo, 2) +var file_jupyter_JupyterServerHostService_v1_proto_goTypes = []interface{}{ (*GetRunningServerRequest)(nil), // 0: Codespaces.Grpc.JupyterServerHostService.v1.GetRunningServerRequest (*GetRunningServerResponse)(nil), // 1: Codespaces.Grpc.JupyterServerHostService.v1.GetRunningServerResponse } -var file_JupyterServerHostService_v1_proto_depIdxs = []int32{ +var file_jupyter_JupyterServerHostService_v1_proto_depIdxs = []int32{ 0, // 0: Codespaces.Grpc.JupyterServerHostService.v1.JupyterServerHost.GetRunningServer:input_type -> Codespaces.Grpc.JupyterServerHostService.v1.GetRunningServerRequest 1, // 1: Codespaces.Grpc.JupyterServerHostService.v1.JupyterServerHost.GetRunningServer:output_type -> Codespaces.Grpc.JupyterServerHostService.v1.GetRunningServerResponse 1, // [1:2] is the sub-list for method output_type @@ -189,13 +189,13 @@ var file_JupyterServerHostService_v1_proto_depIdxs = []int32{ 0, // [0:0] is the sub-list for field type_name } -func init() { file_JupyterServerHostService_v1_proto_init() } -func file_JupyterServerHostService_v1_proto_init() { - if File_JupyterServerHostService_v1_proto != nil { +func init() { file_jupyter_JupyterServerHostService_v1_proto_init() } +func file_jupyter_JupyterServerHostService_v1_proto_init() { + if File_jupyter_JupyterServerHostService_v1_proto != nil { return } if !protoimpl.UnsafeEnabled { - file_JupyterServerHostService_v1_proto_msgTypes[0].Exporter = func(v interface{}, i int) interface{} { + file_jupyter_JupyterServerHostService_v1_proto_msgTypes[0].Exporter = func(v interface{}, i int) interface{} { switch v := v.(*GetRunningServerRequest); i { case 0: return &v.state @@ -207,7 +207,7 @@ func file_JupyterServerHostService_v1_proto_init() { return nil } } - file_JupyterServerHostService_v1_proto_msgTypes[1].Exporter = func(v interface{}, i int) interface{} { + file_jupyter_JupyterServerHostService_v1_proto_msgTypes[1].Exporter = func(v interface{}, i int) interface{} { switch v := v.(*GetRunningServerResponse); i { case 0: return &v.state @@ -224,18 +224,18 @@ func file_JupyterServerHostService_v1_proto_init() { out := protoimpl.TypeBuilder{ File: protoimpl.DescBuilder{ GoPackagePath: reflect.TypeOf(x{}).PkgPath(), - RawDescriptor: file_JupyterServerHostService_v1_proto_rawDesc, + RawDescriptor: file_jupyter_JupyterServerHostService_v1_proto_rawDesc, NumEnums: 0, NumMessages: 2, NumExtensions: 0, NumServices: 1, }, - GoTypes: file_JupyterServerHostService_v1_proto_goTypes, - DependencyIndexes: file_JupyterServerHostService_v1_proto_depIdxs, - MessageInfos: file_JupyterServerHostService_v1_proto_msgTypes, + GoTypes: file_jupyter_JupyterServerHostService_v1_proto_goTypes, + DependencyIndexes: file_jupyter_JupyterServerHostService_v1_proto_depIdxs, + MessageInfos: file_jupyter_JupyterServerHostService_v1_proto_msgTypes, }.Build() - File_JupyterServerHostService_v1_proto = out.File - file_JupyterServerHostService_v1_proto_rawDesc = nil - file_JupyterServerHostService_v1_proto_goTypes = nil - file_JupyterServerHostService_v1_proto_depIdxs = nil + File_jupyter_JupyterServerHostService_v1_proto = out.File + file_jupyter_JupyterServerHostService_v1_proto_rawDesc = nil + file_jupyter_JupyterServerHostService_v1_proto_goTypes = nil + file_jupyter_JupyterServerHostService_v1_proto_depIdxs = nil } diff --git a/internal/codespaces/grpc/jupyter/JupyterServerHostService.v1_grpc.pb.go b/internal/codespaces/grpc/jupyter/JupyterServerHostService.v1_grpc.pb.go index 8ba53014d..789a9df91 100644 --- a/internal/codespaces/grpc/jupyter/JupyterServerHostService.v1_grpc.pb.go +++ b/internal/codespaces/grpc/jupyter/JupyterServerHostService.v1_grpc.pb.go @@ -1,8 +1,8 @@ // Code generated by protoc-gen-go-grpc. DO NOT EDIT. // versions: // - protoc-gen-go-grpc v1.2.0 -// - protoc v3.21.3 -// source: JupyterServerHostService.v1.proto +// - protoc v3.12.4 +// source: jupyter/JupyterServerHostService.v1.proto package jupyter @@ -101,5 +101,5 @@ var JupyterServerHost_ServiceDesc = grpc.ServiceDesc{ }, }, Streams: []grpc.StreamDesc{}, - Metadata: "JupyterServerHostService.v1.proto", + Metadata: "jupyter/JupyterServerHostService.v1.proto", } From c020d602ffe1a5624d4fabc94a48077932b1a5bb Mon Sep 17 00:00:00 2001 From: JP Ungaretti Date: Fri, 4 Nov 2022 20:14:48 +0000 Subject: [PATCH 2/4] Remove extra generation --- internal/codespaces/grpc/generate.sh | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/codespaces/grpc/generate.sh b/internal/codespaces/grpc/generate.sh index e88dc156f..0aff3868a 100755 --- a/internal/codespaces/grpc/generate.sh +++ b/internal/codespaces/grpc/generate.sh @@ -21,7 +21,6 @@ function generate { echo "Generated protocol buffers for $contract" } -generate codespace/CodespaceHostService.v1.proto generate jupyter/JupyterServerHostService.v1.proto echo 'Done!' From 95542a8211e9e16bfcc81a2744f10e385ffe0322 Mon Sep 17 00:00:00 2001 From: JP Ungaretti Date: Fri, 4 Nov 2022 20:28:47 +0000 Subject: [PATCH 3/4] Remove colon from header --- internal/codespaces/grpc/generate.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/codespaces/grpc/generate.md b/internal/codespaces/grpc/generate.md index 7cc18430b..06784735e 100644 --- a/internal/codespaces/grpc/generate.md +++ b/internal/codespaces/grpc/generate.md @@ -2,7 +2,7 @@ Instructions for generating and adding gRPC protocol buffers. -## Generate Protocol Buffers: +## Generate Protocol Buffers 1. [Download `protoc`](https://grpc.io/docs/protoc-installation/) 2. [Download protocol compiler plugins for Go](https://grpc.io/docs/languages/go/quickstart/) From 67236841eef7d622694bd633657a5200d6815b23 Mon Sep 17 00:00:00 2001 From: JP Ungaretti Date: Fri, 4 Nov 2022 20:30:41 +0000 Subject: [PATCH 4/4] Specify directory for generate.sh --- internal/codespaces/grpc/generate.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/codespaces/grpc/generate.md b/internal/codespaces/grpc/generate.md index 06784735e..7ae1dcc1a 100644 --- a/internal/codespaces/grpc/generate.md +++ b/internal/codespaces/grpc/generate.md @@ -6,7 +6,7 @@ Instructions for generating and adding gRPC protocol buffers. 1. [Download `protoc`](https://grpc.io/docs/protoc-installation/) 2. [Download protocol compiler plugins for Go](https://grpc.io/docs/languages/go/quickstart/) -3. Run `./generate.sh` +3. Run `./generate.sh` from the `internal/codespaces/grpc` directory ## Add New Protocol Buffers