From e4b2ec202d28696cecf276f9a409d0de6b2bdda0 Mon Sep 17 00:00:00 2001 From: ravocean Date: Sun, 23 May 2021 15:57:29 -0700 Subject: [PATCH 1/2] We added a few flags based on priority --- pkg/cmd/browse/browse.go | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go index 3e065399e..3470095c4 100644 --- a/pkg/cmd/browse/browse.go +++ b/pkg/cmd/browse/browse.go @@ -24,6 +24,10 @@ type BrowseOptions struct { SelectorArg string FileArg string // Used for storing the file path NumberArg int // Used for storing pull request number + + ProjectFlag bool + WikiFlag bool + SettingsFlag bool } func NewCmdBrowse(f *cmdutil.Factory) *cobra.Command { @@ -49,6 +53,10 @@ func NewCmdBrowse(f *cmdutil.Factory) *cobra.Command { }, } + cmd.Flags().BoolVarP(&opts.ProjectFlag, "project", "p", false, "Open projects tab in browser") + cmd.Flags().BoolVarP(&opts.WikiFlag, "wiki", "w", false, "Opens the wiki in browser") + cmd.Flags().BoolVarP(&opts.SettingsFlag, "settings", "s", false, "Opens the settings in browse") + return cmd } @@ -86,11 +94,3 @@ func parseArgs(opts *BrowseOptions) { } } } - -func parseFlags(opts *BrowseOptions) { - -} - -//hello - -//making pull request From b22519309f2e798b4ce06bda5e7ff9ad6c046282 Mon Sep 17 00:00:00 2001 From: ravocean Date: Sun, 23 May 2021 16:01:18 -0700 Subject: [PATCH 2/2] Fixed the name of projects flag --- pkg/cmd/browse/browse.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go index 3470095c4..eabdf4c5a 100644 --- a/pkg/cmd/browse/browse.go +++ b/pkg/cmd/browse/browse.go @@ -25,7 +25,7 @@ type BrowseOptions struct { FileArg string // Used for storing the file path NumberArg int // Used for storing pull request number - ProjectFlag bool + ProjectsFlag bool WikiFlag bool SettingsFlag bool } @@ -53,7 +53,7 @@ func NewCmdBrowse(f *cmdutil.Factory) *cobra.Command { }, } - cmd.Flags().BoolVarP(&opts.ProjectFlag, "project", "p", false, "Open projects tab in browser") + cmd.Flags().BoolVarP(&opts.ProjectsFlag, "projects", "p", false, "Open projects tab in browser") cmd.Flags().BoolVarP(&opts.WikiFlag, "wiki", "w", false, "Opens the wiki in browser") cmd.Flags().BoolVarP(&opts.SettingsFlag, "settings", "s", false, "Opens the settings in browse")