diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go index 19d7b5e6e..094a5be82 100644 --- a/pkg/cmd/browse/browse.go +++ b/pkg/cmd/browse/browse.go @@ -167,7 +167,7 @@ func parseSection(baseRepo ghrepo.Interface, opts *BrowseOptions) (string, error } if isNumber(opts.SelectorArg) { - return fmt.Sprintf("issues/%s", opts.SelectorArg), nil + return fmt.Sprintf("issues/%s", strings.TrimPrefix(opts.SelectorArg, "#")), nil } if isCommit(opts.SelectorArg) { @@ -253,7 +253,7 @@ func parseFile(opts BrowseOptions, f string) (p string, start int, end int, err } func isNumber(arg string) bool { - _, err := strconv.Atoi(arg) + _, err := strconv.Atoi(strings.TrimPrefix(arg, "#")) return err == nil } diff --git a/pkg/cmd/browse/browse_test.go b/pkg/cmd/browse/browse_test.go index aa9034b78..ba12f6bdf 100644 --- a/pkg/cmd/browse/browse_test.go +++ b/pkg/cmd/browse/browse_test.go @@ -222,6 +222,14 @@ func Test_runBrowse(t *testing.T) { baseRepo: ghrepo.New("kevin", "MinTy"), expectedURL: "https://github.com/kevin/MinTy/issues/217", }, + { + name: "issue with hashtag argument", + opts: BrowseOptions{ + SelectorArg: "#217", + }, + baseRepo: ghrepo.New("kevin", "MinTy"), + expectedURL: "https://github.com/kevin/MinTy/issues/217", + }, { name: "branch flag", opts: BrowseOptions{