From acc362f9d8977412386b6724f7444768be92bcd8 Mon Sep 17 00:00:00 2001 From: Harvey Sanders Date: Sun, 3 Sep 2023 19:55:27 -0400 Subject: [PATCH] Fix pagination resp with "Link" header --- pkg/cmd/run/view/view_test.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/pkg/cmd/run/view/view_test.go b/pkg/cmd/run/view/view_test.go index e2a2a2456..1bef02fc3 100644 --- a/pkg/cmd/run/view/view_test.go +++ b/pkg/cmd/run/view/view_test.go @@ -6,6 +6,7 @@ import ( "fmt" "io" "net/http" + "net/url" "testing" "time" @@ -1278,9 +1279,12 @@ func TestViewRun(t *testing.T) { httpmock.REST("GET", "repos/OWNER/REPO/actions/workflows/123"), httpmock.JSONResponse(shared.TestWorkflow)) reg.Register( - httpmock.REST("GET", "runs/3/jobs"), - httpmock.JSONResponse(shared.JobsPayload{TotalCount: len(jobs), Jobs: firstPage})) - // /runs/:runID/jobs endpoint should be called once more to fetch the remaining jobs + httpmock.QueryMatcher("GET", "runs/3/jobs", url.Values{"per_page": []string{"100"}}), + httpmock.WithHeader( + httpmock.JSONResponse(shared.JobsPayload{TotalCount: len(jobs), Jobs: firstPage}), + "Link", + `; rel="next", ; rel="last"`), + ) reg.Register( httpmock.REST("GET", "runs/3/jobs"), httpmock.JSONResponse(shared.JobsPayload{TotalCount: len(jobs), Jobs: secondPage}))