From ad2cfe074ff18efcd6ff5ee3314a2eaba7454527 Mon Sep 17 00:00:00 2001 From: Cody Soyland Date: Thu, 13 Feb 2025 10:18:30 -0500 Subject: [PATCH] Add mutex to fix race in attestation test client Signed-off-by: Cody Soyland --- pkg/cmd/attestation/api/mock_httpClient_test.go | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkg/cmd/attestation/api/mock_httpClient_test.go b/pkg/cmd/attestation/api/mock_httpClient_test.go index 26933ae2e..b082d13d2 100644 --- a/pkg/cmd/attestation/api/mock_httpClient_test.go +++ b/pkg/cmd/attestation/api/mock_httpClient_test.go @@ -5,6 +5,7 @@ import ( "fmt" "io" "net/http" + "sync" "github.com/cli/cli/v2/pkg/cmd/attestation/test/data" "github.com/golang/snappy" @@ -58,12 +59,16 @@ func (m *reqFailHttpClient) Get(url string) (*http.Response, error) { type failAfterNCallsHttpClient struct { mock.Mock + mu sync.Mutex FailOnCallN int FailOnAllSubsequentCalls bool NumCalls int } func (m *failAfterNCallsHttpClient) Get(url string) (*http.Response, error) { + m.mu.Lock() + defer m.mu.Unlock() + m.On("OnGetFailAfterNCalls").Return() m.NumCalls++