STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Guard against leaked parameters in issue/pr create tests

Browse source
This commit is contained in:
Mislav Marohnić 2020-05-12 16:49:04 +02:00
parent 386a53c34a
commit b75c4a812d
2 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
command/issue_test.go
View file

@ -556,6 +556,12 @@ func TestIssueCreate_metadata(t *testing.T) {
eq(t, inputs["labelIds"], []interface{}{"BUGID", "TODOID"})
eq(t, inputs["projectIds"], []interface{}{"ROADMAPID"})
eq(t, inputs["milestoneId"], "BIGONEID")
if v, ok := inputs["userIds"]; ok {
t.Errorf("did not expect userIds: %v", v)
}
if v, ok := inputs["teamIds"]; ok {
t.Errorf("did not expect teamIds: %v", v)
}
}))
output, err := RunCommand(`issue create -t TITLE -b BODY -a monalisa -l bug -l todo -p roadmap -m 'big one.oh'`)

6
command/pr_create_test.go
View file

@ -141,6 +141,12 @@ func TestPRCreate_metadata(t *testing.T) {
`, func(inputs map[string]interface{}) {
eq(t, inputs["title"], "TITLE")
eq(t, inputs["body"], "BODY")
if v, ok := inputs["assigneeIds"]; ok {
t.Errorf("did not expect assigneeIds: %v", v)
}
if v, ok := inputs["userIds"]; ok {
t.Errorf("did not expect userIds: %v", v)
}
}))
http.Register(
httpmock.GraphQL(`\bupdatePullRequest\(`),