From b808612769806a754dbc94f138e3cecd054a930a Mon Sep 17 00:00:00 2001 From: Trevor Rosen Date: Fri, 24 Oct 2025 13:45:16 -0500 Subject: [PATCH] Remove skipped tests Signed-off-by: Trevor Rosen --- .../attestation/verification/sigstore_test.go | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/pkg/cmd/attestation/verification/sigstore_test.go b/pkg/cmd/attestation/verification/sigstore_test.go index 78269d008..1f7c925ba 100644 --- a/pkg/cmd/attestation/verification/sigstore_test.go +++ b/pkg/cmd/attestation/verification/sigstore_test.go @@ -27,14 +27,6 @@ func TestChooseVerifierWithNilPublicGood(t *testing.T) { require.ErrorContains(t, err, "public good verifier is not available") } -// TestChooseVerifierWithGitHubIssuer tests that chooseVerifier can select -// GitHub verifier even when PGI verifier is nil. -func TestChooseVerifierWithGitHubIssuer(t *testing.T) { - // We'll test this scenario with the actual initialization - // to ensure GitHub verifier is properly created - t.Skip("This requires integration test with actual TUF client - covered by integration tests") -} - // TestChooseVerifierUnrecognizedIssuer tests that an error is returned // for unrecognized issuers. func TestChooseVerifierUnrecognizedIssuer(t *testing.T) { @@ -49,14 +41,6 @@ func TestChooseVerifierUnrecognizedIssuer(t *testing.T) { require.ErrorContains(t, err, "leaf certificate issuer is not recognized") } -// TestGetBundleIssuer tests the getBundleIssuer helper function -func TestGetBundleIssuer(t *testing.T) { - // This test would require setting up a mock bundle - // For now, we'll just verify it exists and can be called - // Integration tests cover the actual functionality - t.Skip("getBundleIssuer requires a valid bundle which needs integration test setup") -} - func TestLiveSigstoreVerifier_noVerifierSet(t *testing.T) { verifier := &LiveSigstoreVerifier{ Logger: io.NewTestHandler(),