Merge branch 'cli:trunk' into trunk
This commit is contained in:
commit
bb1a6f262a
207 changed files with 8341 additions and 1262 deletions
20
.github/CONTRIBUTING.md
vendored
20
.github/CONTRIBUTING.md
vendored
|
|
@ -6,9 +6,10 @@ We accept pull requests for bug fixes and features where we've discussed the app
|
|||
|
||||
Please do:
|
||||
|
||||
* Check existing issues to verify that the [bug][bug issues] or [feature request][feature request issues] has not already been submitted.
|
||||
* Check issues to verify that a [bug][bug issues] or [feature request][feature request issues] issue does not already exist for the same problem or feature.
|
||||
* Open an issue if things aren't working as expected.
|
||||
* Open an issue to propose a significant change.
|
||||
* Open an issue to propose a design for an issue labelled [`needs-design` and `help wanted`][needs design and help wanted], following the [proposing a design guidelines](#proposing-a-design) instructions below.
|
||||
* Open a pull request to fix a bug.
|
||||
* Open a pull request to fix documentation about a command.
|
||||
* Open a pull request for any issue labelled [`help wanted`][hw] or [`good first issue`][gfi].
|
||||
|
|
@ -52,7 +53,21 @@ We generate manual pages from source on every release. You do not need to submit
|
|||
|
||||
## Design guidelines
|
||||
|
||||
You may reference the [CLI Design System][] when suggesting features, and are welcome to use our [Google Docs Template][] to suggest designs.
|
||||
### Proposing a design
|
||||
|
||||
You may propose a design to solve an open bug or feature request issue that has both [the `needs-design` and `help-wanted` labels][needs design and help wanted].
|
||||
|
||||
To propose a design:
|
||||
|
||||
- Open a new issue using the [design proposal issue template](./ISSUE_TEMPLATE/submit-a-design-proposal.md).
|
||||
- Include a link to the issue that the design is for.
|
||||
- Describe the design you are proposing to resolve the issue, leveraging the [CLI Design System][].
|
||||
- Mock up the design you are proposing using our [Google Docs Template][] or code blocks.
|
||||
- Mock ups should cleary illustrate the command(s) being run and the expected output(s).
|
||||
|
||||
### (core team only) Revewing a design
|
||||
|
||||
A member of the core team will [triage](../docs/triage.md) the design proposal. Once a member of the core team has reviewed the design, they may add the [`help wanted`][hw] label to the issue, so a PR can be opened to provide the implementation.
|
||||
|
||||
## Resources
|
||||
|
||||
|
|
@ -62,6 +77,7 @@ You may reference the [CLI Design System][] when suggesting features, and are we
|
|||
|
||||
|
||||
[bug issues]: https://github.com/cli/cli/issues?q=is%3Aopen+is%3Aissue+label%3Abug
|
||||
[needs design and help wanted]: https://github.com/cli/cli/issues?q=state%3Aclosed%20is%3Aissue%20label%3Aneeds-design%20label%3A%22help%20wanted%22
|
||||
[feature request issues]: https://github.com/cli/cli/issues?q=is%3Aopen+is%3Aissue+label%3Aenhancement
|
||||
[hw]: https://github.com/cli/cli/labels/help%20wanted
|
||||
[gfi]: https://github.com/cli/cli/labels/good%20first%20issue
|
||||
|
|
|
|||
58
.github/ISSUE_TEMPLATE/submit-a-design-proposal.md
vendored
Normal file
58
.github/ISSUE_TEMPLATE/submit-a-design-proposal.md
vendored
Normal file
|
|
@ -0,0 +1,58 @@
|
|||
---
|
||||
name: "🎨 Submit a design proposal"
|
||||
about: Submit a design to resolve an open issue that has both `needs-design` and `help-wanted` labels
|
||||
title: ''
|
||||
labels: enhancement
|
||||
assignees: ''
|
||||
|
||||
---
|
||||
|
||||
<!-- See [CONTRIBUTING.md](../CONTRIBUTING.md#proposing-a-design) for more information.-->
|
||||
|
||||
### Link to issue for design submission
|
||||
|
||||
<!--
|
||||
Provide a link to the issue this design is for.
|
||||
|
||||
All design submissions must be linked to an open issue that
|
||||
has both the `needs-design` and `help-wanted` labels.
|
||||
-->
|
||||
|
||||
### Proposed Design
|
||||
|
||||
<!--
|
||||
Describe the design you are proposing to resolve the issue.
|
||||
|
||||
All CLI designs must adhere to the [Primer CLI design reference](https://primer.style/cli/).
|
||||
-->
|
||||
|
||||
### Mockup
|
||||
|
||||
<!--
|
||||
Provide a mockup of the design you are proposing. All mockups should clearly illustrate the command(s) being run and the expected output(s).
|
||||
|
||||
When color and formatting are important, consider using our [CLI design Google Docs Template](https://docs.google.com/document/d/1JIRErIUuJ6fTgabiFYfCH3x91pyHuytbfa0QLnTfXKM/edit#heading=h.or54sa47ylpg).
|
||||
|
||||
Code blocks can also be used to submit a design mockup - remember to include the command(s) being run. Example:
|
||||
|
||||
```shell
|
||||
$ gh issue list --json title -L 5
|
||||
[
|
||||
{
|
||||
"title": "`gh pr checks <pr> --required` should not fail when there are no required checks"
|
||||
},
|
||||
{
|
||||
"title": "gh pr view commits should include commit description"
|
||||
},
|
||||
{
|
||||
"title": "Adapt the color of the device code to the color used by the terminal"
|
||||
},
|
||||
{
|
||||
"title": "`gh pr create` does not default to fork when user has write access to upstream"
|
||||
},
|
||||
{
|
||||
"title": "First party discussions support"
|
||||
}
|
||||
]
|
||||
```
|
||||
-->
|
||||
5
.github/SECURITY.md
vendored
5
.github/SECURITY.md
vendored
|
|
@ -2,7 +2,10 @@ GitHub takes the security of our software products and services seriously, inclu
|
|||
|
||||
If you believe you have found a security vulnerability in GitHub CLI, you can report it to us in one of two ways:
|
||||
|
||||
* Report it to this repository directly using [private vulnerability reporting][]. Such reports are not eligible for a bounty reward.
|
||||
* Report it to this repository directly using [private vulnerability reporting][].
|
||||
* Include a description of your investigation of the GitHub CLI's codebase and why you believe an exploit is possible.
|
||||
* POCs and links to code are greatly encouraged.
|
||||
* Such reports are not eligible for a bounty reward.
|
||||
|
||||
* Submit the report through [HackerOne][] to be eligible for a bounty reward.
|
||||
|
||||
|
|
|
|||
2
.github/workflows/deployment.yml
vendored
2
.github/workflows/deployment.yml
vendored
|
|
@ -299,7 +299,7 @@ jobs:
|
|||
rpmsign --addsign dist/*.rpm
|
||||
- name: Attest release artifacts
|
||||
if: inputs.environment == 'production'
|
||||
uses: actions/attest-build-provenance@310b0a4a3b0b78ef57ecda988ee04b132db73ef8 # v1.4.1
|
||||
uses: actions/attest-build-provenance@1c608d11d69870c2092266b3f9a6f3abbf17002c # v1.4.3
|
||||
with:
|
||||
subject-path: "dist/gh_*"
|
||||
- name: Run createrepo
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue