STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(discussion create): allow --repo override

Browse source 
Signed-off-by: Babak K. Shandiz <babakks@github.com>
This commit is contained in:
Babak K. Shandiz 2026-05-07 08:58:53 +01:00
parent 3850cacb55
commit bdceb21248
No known key found for this signature in database
GPG key ID: 9472CAEFF56C742E
2 changed files with 31 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pkg/cmd/discussion/create/create.go
View file

@ -80,6 +80,8 @@ func NewCmdCreate(f *cmdutil.Factory, runF func(*CreateOptions) error) *cobra.Co
},
}
cmdutil.EnableRepoOverride(cmd, f)
cmd.Flags().StringVarP(&opts.Title, "title", "t", "", "Title for the discussion")
cmd.Flags().StringVarP(&opts.Body, "body", "b", "", "Body for the discussion")
cmd.Flags().StringVarP(&opts.Category, "category", "c", "", "Category name or slug for the discussion")

40
pkg/cmd/discussion/create/create_test.go
View file

@ -33,11 +33,12 @@ func sampleDiscussion() *client.Discussion {
func TestNewCmdCreate(t *testing.T) {
tests := []struct {
name string
args string
isTTY bool
wantOpts CreateOptions
wantErr string
name string
args string
isTTY bool
wantOpts CreateOptions
wantBaseRepo ghrepo.Interface
wantErr string
}{
{
name: "no flags",
@ -86,6 +87,17 @@ func TestNewCmdCreate(t *testing.T) {
isTTY: true,
wantErr: "body cannot be blank",
},
{
name: "repo override",
args: "--title 'Test' --body 'Body' --category 'Q&A' -R OWNER/REPO",
isTTY: true,
wantBaseRepo: ghrepo.New("OWNER", "REPO"),
wantOpts: CreateOptions{
Title: "Test",
Body: "Body",
Category: "Q&A",
},
},
}
for _, tt := range tests {
@ -94,9 +106,9 @@ func TestNewCmdCreate(t *testing.T) {
ios.SetStdinTTY(tt.isTTY)
ios.SetStdoutTTY(tt.isTTY)
f := &cmdutil.Factory{IOStreams: ios}
var capturedOpts *CreateOptions
var gotOpts *CreateOptions
cmd := NewCmdCreate(f, func(opts *CreateOptions) error {
capturedOpts = opts
gotOpts = opts
return nil
})
cmd.SetIn(&bytes.Buffer{})
@ -114,10 +126,16 @@ func TestNewCmdCreate(t *testing.T) {
return
}
require.NoError(t, err)
assert.Equal(t, tt.wantOpts.Title, capturedOpts.Title)
assert.Equal(t, tt.wantOpts.Body, capturedOpts.Body)
assert.Equal(t, tt.wantOpts.Category, capturedOpts.Category)
assert.Equal(t, tt.wantOpts.Labels, capturedOpts.Labels)
assert.Equal(t, tt.wantOpts.Title, gotOpts.Title)
assert.Equal(t, tt.wantOpts.Body, gotOpts.Body)
assert.Equal(t, tt.wantOpts.Category, gotOpts.Category)
assert.Equal(t, tt.wantOpts.Labels, gotOpts.Labels)
if tt.wantBaseRepo != nil {
baseRepo, err := gotOpts.BaseRepo()
require.NoError(t, err)
assert.True(t, ghrepo.IsSame(tt.wantBaseRepo, baseRepo))
}
})
}
}