STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #243 from github/display-url

Browse source 
Extract helper for URL display
This commit is contained in:
Nate Smith 2020-01-23 09:36:40 -06:00 • committed by GitHub
commit bf0f345ea3
2 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

14
command/issue.go
View file

@ -354,11 +354,7 @@ func issueCreate(cmd *cobra.Command, args []string) error {
url.QueryEscape(body),
)
// TODO could exceed max url length for explorer
url, err := url.Parse(openURL)
if err != nil {
return err
}
fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s%s in your browser.\n", url.Host, url.Path)
fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s in your browser.\n", displayURL(openURL))
return utils.OpenInBrowser(openURL)
} else if action == SubmitAction {
params := map[string]interface{}{
@ -417,3 +413,11 @@ func labelList(issue api.Issue) string {
}
return list
}
func displayURL(urlStr string) string {
u, err := url.Parse(urlStr)
if err != nil {
return urlStr
}
return u.Hostname() + u.Path
}

6
command/pr_create.go
View file

@ -200,11 +200,7 @@ func prCreate(cmd *cobra.Command, _ []string) error {
url.QueryEscape(body),
)
// TODO could exceed max url length for explorer
url, err := url.Parse(openURL)
if err != nil {
return err
}
fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s%s in your browser.\n", url.Host, url.Path)
fmt.Fprintf(cmd.ErrOrStderr(), "Opening %s in your browser.\n", displayURL(openURL))
return utils.OpenInBrowser(openURL)
} else {
panic("Unreachable state")