STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid using named return in PR ChecksStatus

Browse source 
See: https://dave.cheney.net/practical-go/presentations/gophercon-israel.html#_avoid_named_return_values
This commit is contained in:
William Martin 2023-05-16 19:43:07 +02:00
parent c4bb344ddd
commit bfb5e8f1d6
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
api/queries_pr.go
View file

@ -261,9 +261,11 @@ type PullRequestChecksStatus struct {
Total int
}
func (pr *PullRequest) ChecksStatus() (summary PullRequestChecksStatus) {
func (pr *PullRequest) ChecksStatus() PullRequestChecksStatus {
var summary PullRequestChecksStatus
if len(pr.StatusCheckRollup.Nodes) == 0 {
return
return summary
}
commit := pr.StatusCheckRollup.Nodes[0].Commit
@ -295,7 +297,7 @@ func (pr *PullRequest) ChecksStatus() (summary PullRequestChecksStatus) {
summary.Total++
}
return
return summary
}
func (pr *PullRequest) DisplayableReviews() PullRequestReviews {