From bfb5e8f1d6bef0f161271a26578fba7baf22b05f Mon Sep 17 00:00:00 2001
From: William Martin <williammartin@github.com>
Date: Tue, 16 May 2023 19:43:07 +0200
Subject: [PATCH] Avoid using named return in PR ChecksStatus

See: https://dave.cheney.net/practical-go/presentations/gophercon-israel.html#_avoid_named_return_values
---
 api/queries_pr.go | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/api/queries_pr.go b/api/queries_pr.go
index 5ae5cbb8f..6f121caab 100644
--- a/api/queries_pr.go
+++ b/api/queries_pr.go
@@ -261,9 +261,11 @@ type PullRequestChecksStatus struct {
 	Total   int
 }
 
-func (pr *PullRequest) ChecksStatus() (summary PullRequestChecksStatus) {
+func (pr *PullRequest) ChecksStatus() PullRequestChecksStatus {
+	var summary PullRequestChecksStatus
+
 	if len(pr.StatusCheckRollup.Nodes) == 0 {
-		return
+		return summary
 	}
 
 	commit := pr.StatusCheckRollup.Nodes[0].Commit
@@ -295,7 +297,7 @@ func (pr *PullRequest) ChecksStatus() (summary PullRequestChecksStatus) {
 		summary.Total++
 	}
 
-	return
+	return summary
 }
 
 func (pr *PullRequest) DisplayableReviews() PullRequestReviews {