From 327dae95a30b31eed077b733c0664f8bba6f9dfd Mon Sep 17 00:00:00 2001 From: Dasio Date: Mon, 24 Feb 2020 21:18:34 +0100 Subject: [PATCH] Use break label instead of goto --- api/queries_pr.go | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/api/queries_pr.go b/api/queries_pr.go index 734245acb..b6fdcb271 100644 --- a/api/queries_pr.go +++ b/api/queries_pr.go @@ -497,7 +497,7 @@ func PullRequestList(client *Client, vars map[string]interface{}, limit int) ([] } }` - prs := []PullRequest{} + var prs []PullRequest pageLimit := min(limit, 100) variables := map[string]interface{}{} @@ -555,7 +555,7 @@ func PullRequestList(client *Client, vars map[string]interface{}, limit int) ([] variables[name] = val } } - +loop: for { variables["limit"] = pageLimit var data response @@ -571,17 +571,16 @@ func PullRequestList(client *Client, vars map[string]interface{}, limit int) ([] for _, edge := range prData.Edges { prs = append(prs, edge.Node) if len(prs) == limit { - goto done + break loop } } if prData.PageInfo.HasNextPage { variables["endCursor"] = prData.PageInfo.EndCursor pageLimit = min(pageLimit, limit-len(prs)) - continue + } else { + break } - done: - break } return prs, nil