STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Avoid using keyring unnecessarily in AuthConfig tests

Browse source 
This is to avoid the impression that the keyring matters, when the test
is actually about general auth behaviour
This commit is contained in:
William Martin 2023-10-19 12:26:52 +02:00
parent fa80802c81
commit c9de817865
1 changed files with 7 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

17
internal/config/auth_config_test.go
View file

@ -286,12 +286,11 @@ func TestLoginSetsUserForProvidedHost(t *testing.T) {
tempDir := t.TempDir()
t.Setenv("GH_CONFIG_DIR", tempDir)
// Given a usable keyring and an empty config
keyring.MockInit()
// Given we are not logged in
authCfg := newTestAuthConfig()
// When we login
_, err := authCfg.Login("github.com", "test-user", "test-token", "ssh", true)
_, err := authCfg.Login("github.com", "test-user", "test-token", "ssh", false)
// Then it returns success and the user is set
require.NoError(t, err)
@ -301,16 +300,15 @@ func TestLoginSetsUserForProvidedHost(t *testing.T) {
require.Equal(t, "test-user", user)
}
func TestLoginSetsGitProtocolForProdivdedHost(t *testing.T) {
func TestLoginSetsGitProtocolForProvidedHost(t *testing.T) {
tempDir := t.TempDir()
t.Setenv("GH_CONFIG_DIR", tempDir)
// Given a usable keyring and an empty config
keyring.MockInit()
// Given we are not logged in
authCfg := newTestAuthConfig()
// When we login
_, err := authCfg.Login("github.com", "test-user", "test-token", "ssh", true)
_, err := authCfg.Login("github.com", "test-user", "test-token", "ssh", false)
// Then it returns success and the git protocol is set
require.NoError(t, err)
@ -324,12 +322,11 @@ func TestLoginAddsHostIfNotAlreadyAdded(t *testing.T) {
tempDir := t.TempDir()
t.Setenv("GH_CONFIG_DIR", tempDir)
// Given a usable keyring and an empty config
keyring.MockInit()
// Given we are not logged in
authCfg := newTestAuthConfig()
// When we login
_, err := authCfg.Login("github.com", "test-user", "test-token", "ssh", true)
_, err := authCfg.Login("github.com", "test-user", "test-token", "ssh", false)
// Then it returns success and a host is added
require.NoError(t, err)