From ca8d878d80f44ec991968d91021f95c87bf1458b Mon Sep 17 00:00:00 2001 From: "Babak K. Shandiz" Date: Fri, 24 Apr 2026 21:54:35 +0100 Subject: [PATCH] docs(discussion/shared): explain why we accept http scheme Signed-off-by: Babak K. Shandiz --- pkg/cmd/discussion/shared/lookup.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/cmd/discussion/shared/lookup.go b/pkg/cmd/discussion/shared/lookup.go index 98fdacd13..e754568f0 100644 --- a/pkg/cmd/discussion/shared/lookup.go +++ b/pkg/cmd/discussion/shared/lookup.go @@ -29,6 +29,9 @@ func ParseDiscussionArg(arg string) (int, ghrepo.Interface, error) { return 0, nil, fmt.Errorf("invalid discussion argument: %q", arg) } + // Note that an HTTP URL is also okay, because we're just using the URL to find + // the discussion number, repo and host, and we wont be unsecure HTTP API calls. + m := discussionURLRE.FindStringSubmatch(u.Path) if m == nil { return 0, nil, fmt.Errorf("invalid discussion URL: %q", arg)