From cb7672e573735dee89df241844a0c4519f0e9837 Mon Sep 17 00:00:00 2001 From: William Martin Date: Thu, 19 Oct 2023 12:05:40 +0200 Subject: [PATCH] Add additional comment on Logout ignoring errors --- internal/config/auth_config_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/internal/config/auth_config_test.go b/internal/config/auth_config_test.go index 461ebc723..a1f9b0833 100644 --- a/internal/config/auth_config_test.go +++ b/internal/config/auth_config_test.go @@ -323,6 +323,10 @@ func TestLogoutRemovesHostAndKeyringToken(t *testing.T) { // Note that I'm not sure this test enforces particularly desirable behaviour // since it leads users to believe a token has been removed when really // that might have failed for some reason. +// +// The original intention here is that if the logout fails, the user can't +// really do anything to recover. On the other hand, a user might +// want to rectify this manually, for example if there were on a shared machine. func TestLogoutIgnoresErrorsFromConfigAndKeyring(t *testing.T) { tempDir := t.TempDir() t.Setenv("GH_CONFIG_DIR", tempDir)