From 746ab7354a78dcf9bfae2e3d44c52814353d850a Mon Sep 17 00:00:00 2001 From: vilmibm Date: Tue, 29 Sep 2020 10:47:51 -0500 Subject: [PATCH 1/2] mention new core label in contributing docs --- .github/CONTRIBUTING.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 09f60f318..0b96dae60 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -17,11 +17,13 @@ Please do: * open an issue to propose a significant change * open a pull request to fix a bug * open a pull request to fix documentation about a command -* open a pull request if a member of the GitHub CLI team has given the ok after discussion in an issue +* open a pull request for an issue with the `help-wanted` label and leave a comment claiming it Please avoid: * adding installation instructions specifically for your OS/package manager +* opening pull requests for any issue marked `core`. these issues require additional context from + the core CLI team at GitHub and any external pull requests will not be accepted ## Building the project From 91fcfa548ff0c43cd6b112effebeac12931d3477 Mon Sep 17 00:00:00 2001 From: vilmibm Date: Tue, 29 Sep 2020 11:00:12 -0500 Subject: [PATCH 2/2] Sentence Case. --- .github/CONTRIBUTING.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 0b96dae60..c99d111d7 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -12,18 +12,18 @@ We accept pull requests for bug fixes and features where we've discussed the app Please do: -* check existing issues to verify that the [bug][bug issues] or [feature request][feature request issues] has not already been submitted -* open an issue if things aren't working as expected -* open an issue to propose a significant change -* open a pull request to fix a bug -* open a pull request to fix documentation about a command -* open a pull request for an issue with the `help-wanted` label and leave a comment claiming it +* Check existing issues to verify that the [bug][bug issues] or [feature request][feature request issues] has not already been submitted. +* Open an issue if things aren't working as expected. +* Open an issue to propose a significant change. +* Open a pull request to fix a bug. +* Open a pull request to fix documentation about a command. +* Open a pull request for an issue with the `help-wanted` label and leave a comment claiming it. Please avoid: -* adding installation instructions specifically for your OS/package manager -* opening pull requests for any issue marked `core`. these issues require additional context from - the core CLI team at GitHub and any external pull requests will not be accepted +* Adding installation instructions specifically for your OS/package manager. +* Opening pull requests for any issue marked `core`. These issues require additional context from + the core CLI team at GitHub and any external pull requests will not be accepted. ## Building the project