From cd1c30a41e1443834ae2e5e8aeec1c308dea0240 Mon Sep 17 00:00:00 2001
From: Meredith Lancaster <malancas@github.com>
Date: Tue, 12 Mar 2024 16:39:53 -0600
Subject: [PATCH] fix shellcheck issues

Signed-off-by: Meredith Lancaster <malancas@github.com>
---
 .../download-and-verify-package-attestation.sh | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/test/integration/attestation-cmd/download-and-verify-package-attestation.sh b/test/integration/attestation-cmd/download-and-verify-package-attestation.sh
index 0c024a10a..2a42ff299 100755
--- a/test/integration/attestation-cmd/download-and-verify-package-attestation.sh
+++ b/test/integration/attestation-cmd/download-and-verify-package-attestation.sh
@@ -16,25 +16,25 @@ attestationURL="https://registry.npmjs.org/-/npm/v1/attestations/$labRatPackageN
 
 echo "Testing with package $packageFile and attestation $attestationFile"
 
-curl -s $packageURL -o $packageFile
-curl -s $attestationURL | jq '.attestations[1].bundle' > $attestationFile
+curl -s "$packageURL" -o "$packageFile"
+curl -s "$attestationURL" | jq '.attestations[1].bundle' > "$attestationFile"
 
 # Verify the package with the --owner flag
-$ghBuildPath attestation verify $packageFile -b $attestationFile --digest-alg=sha512 --owner=sigstore
-if [ $? -ne 0 ]; then
+$ghBuildPath attestation verify "$packageFile" -b "$attestationFile" --digest-alg=sha512 --owner=sigstore
+if ! mycmd; then
     # cleanup test data
     echo "Failed to verify package with --owner flag"
-    rm $packageFile $attestationFile
+    rm "$packageFile" "$attestationFile"
     exit 1
 fi
 
-$ghBuildPath attestation verify $packageFile -b $attestationFile --digest-alg=sha512 --repo=sigstore/sigstore-js
-if [ $? -ne 0 ]; then
+$ghBuildPath attestation verify "$packageFile" -b "$attestationFile" --digest-alg=sha512 --repo=sigstore/sigstore-js
+if ! mycmd; then
     # cleanup test data
     echo "Failed to verify package with --repo flag"
-    rm $packageFile $attestationFile
+    rm "$packageFile" "$attestationFile"
     exit 1
 fi
 
 # cleanup test data
-rm $packageFile $attestationFile
+rm "$packageFile" "$attestationFile"