STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add int32 validation to milestone numbers

Browse source
This commit is contained in:
zamasu 2020-10-13 08:36:47 +09:00
parent a2aa07d497
commit d4e6fc11d7
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
api/queries_issue.go
View file

@ -251,8 +251,8 @@ func IssueList(client *Client, repo ghrepo.Interface, state string, labels []str
if milestoneString != "" {
var milestone *RepoMilestone
if milestoneNumber, err := strconv.Atoi(milestoneString); err == nil {
milestone, err = MilestoneByNumber(client, repo, milestoneNumber)
if milestoneNumber, err := strconv.ParseInt(milestoneString, 10, 32); err == nil {
milestone, err = MilestoneByNumber(client, repo, int32(milestoneNumber))
if err != nil {
return nil, err
}

2
api/queries_repo.go
View file

@ -840,7 +840,7 @@ func MilestoneByTitle(client *Client, repo ghrepo.Interface, title string) (*Rep
return nil, fmt.Errorf("no milestone found with title %q", title)
}
func MilestoneByNumber(client *Client, repo ghrepo.Interface, number int) (*RepoMilestone, error) {
func MilestoneByNumber(client *Client, repo ghrepo.Interface, number int32) (*RepoMilestone, error) {
var query struct {
Repository struct {
Milestone *RepoMilestone `graphql:"milestone(number: $number)"`