STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Address PR review comments

Browse source
This commit is contained in:
Azeem Sajid 2025-01-31 12:28:00 +05:00
parent b8d32e5d33
commit d6be4981be
1 changed files with 3 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
pkg/cmd/cache/delete/delete.go vendored
View file

@ -69,7 +69,7 @@ func NewCmdDelete(f *cmdutil.Factory, runF func(*DeleteOptions) error) *cobra.Co
return err
}
if opts.SucceedOnNoCaches && (!opts.DeleteAll || len(args) == 1) {
if !opts.DeleteAll && opts.SucceedOnNoCaches {
return cmdutil.FlagErrorf("--succeed-on-no-caches must be used in conjunction with --all")
}
@ -113,16 +113,11 @@ func deleteRun(opts *DeleteOptions) error {
caches, err := shared.GetCaches(client, repo, shared.GetCachesOptions{Limit: -1})
opts.IO.StopProgressIndicator()
if err != nil {
if opts.SucceedOnNoCaches {
fmt.Println(err)
return nil
} else {
return err
}
return err
}
if len(caches.ActionsCaches) == 0 {
if opts.SucceedOnNoCaches {
fmt.Printf("%s No caches to delete\n", opts.IO.ColorScheme().SuccessIcon())
fmt.Fprintf(opts.IO.Out, "%s No caches to delete\n", opts.IO.ColorScheme().SuccessIcon())
return nil
} else {
return fmt.Errorf("%s No caches to delete", opts.IO.ColorScheme().FailureIcon())