STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(discussion/client): polish Create implementation

Browse source 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This commit is contained in:
Babak K. Shandiz 2026-05-01 09:12:15 +01:00
parent 2e5623180a
commit d78703efaa
No known key found for this signature in database
GPG key ID: 9472CAEFF56C742E
2 changed files with 11 additions and 24 deletions
Download patch file Download diff file Expand all files Collapse all files

28
pkg/cmd/discussion/client/client_impl.go
View file

@ -805,25 +805,13 @@ func (c *discussionClient) getRepositoryMeta(repo ghrepo.Interface) (*repository
}, nil
}
// createDiscussionGQLInput is the typed input for the createDiscussion GraphQL mutation.
type createDiscussionGQLInput struct {
RepositoryID githubv4.ID `json:"repositoryId"`
CategoryID githubv4.ID `json:"categoryId"`
Title githubv4.String `json:"title"`
Body githubv4.String `json:"body"`
}
func (c *discussionClient) Create(repo ghrepo.Interface, input CreateDiscussionInput) (*Discussion, error) {
repoID := input.RepositoryID
if repoID == "" {
meta, err := c.getRepositoryMeta(repo)
if err != nil {
return nil, err
}
if !meta.HasDiscussionsEnabled {
return nil, fmt.Errorf("the '%s/%s' repository has discussions disabled", repo.RepoOwner(), repo.RepoName())
}
repoID = meta.ID
meta, err := c.getRepositoryMeta(repo)
if err != nil {
return nil, err
}
if !meta.HasDiscussionsEnabled {
return nil, fmt.Errorf("the '%s/%s' repository has discussions disabled", repo.RepoOwner(), repo.RepoName())
}
var mutation struct {
@ -838,8 +826,8 @@ func (c *discussionClient) Create(repo ghrepo.Interface, input CreateDiscussionI
}
variables := map[string]interface{}{
"input": createDiscussionGQLInput{
RepositoryID: githubv4.ID(repoID),
"input": githubv4.CreateDiscussionInput{
RepositoryID: githubv4.ID(meta.ID),
CategoryID: githubv4.ID(input.CategoryID),
Title: githubv4.String(input.Title),
Body: githubv4.String(input.Body),

7
pkg/cmd/discussion/client/types.go
View file

@ -327,10 +327,9 @@ type SearchFilters struct {
// CreateDiscussionInput holds the parameters for creating a discussion.
type CreateDiscussionInput struct {
RepositoryID string
CategoryID string
Title string
Body string
CategoryID string
Title string
Body string
}
// UpdateDiscussionInput holds optional parameters for updating a discussion.