STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #4559 from cli/api-pagination-fix

Browse source 
Prevent repeating GET parameters when paginating with api command
This commit is contained in:
Mislav Marohnić 2021-10-19 18:54:17 +02:00 • committed by GitHub
commit d84a7c7fa7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

1
pkg/cmd/api/api.go
View file

@ -319,6 +319,7 @@ func apiRun(opts *ApiOptions) error {
}
} else {
requestPath, hasNextPage = findNextPage(resp)
requestBody = nil // prevent repeating GET parameters
}
if hasNextPage && opts.ShowResponseHeaders {

9
pkg/cmd/api/api_test.go
View file

@ -577,8 +577,11 @@ func Test_apiRun_paginationREST(t *testing.T) {
return config.NewBlankConfig(), nil
},
RequestPath: "issues",
Paginate: true,
RequestMethod: "GET",
RequestMethodPassed: true,
RequestPath: "issues",
Paginate: true,
RawFields: []string{"per_page=50", "page=1"},
}
err := apiRun(&options)
@ -587,7 +590,7 @@ func Test_apiRun_paginationREST(t *testing.T) {
assert.Equal(t, `{"page":1}{"page":2}{"page":3}`, stdout.String(), "stdout")
assert.Equal(t, "", stderr.String(), "stderr")
assert.Equal(t, "https://api.github.com/issues?per_page=100", responses[0].Request.URL.String())
assert.Equal(t, "https://api.github.com/issues?page=1&per_page=50", responses[0].Request.URL.String())
assert.Equal(t, "https://api.github.com/repositories/1227/issues?page=2", responses[1].Request.URL.String())
assert.Equal(t, "https://api.github.com/repositories/1227/issues?page=3", responses[2].Request.URL.String())
}