From d8c20faa65031639264cb837167a09bb14c337c4 Mon Sep 17 00:00:00 2001 From: Ben Date: Wed, 19 May 2021 22:14:58 -0700 Subject: [PATCH] added in a help dialogue and error message --- pkg/cmd/browse/browse.go | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/pkg/cmd/browse/browse.go b/pkg/cmd/browse/browse.go index 5fdfd1065..3a1698051 100644 --- a/pkg/cmd/browse/browse.go +++ b/pkg/cmd/browse/browse.go @@ -26,19 +26,21 @@ func NewCmdBrowse(f *cmdutil.Factory) *cobra.Command { func openInBrowser(cmd *cobra.Command, f *cmdutil.Factory) { // args := cmd.Args baseRepo, err := f.BaseRepo() + w := f.IOStreams.ErrOut + cs := f.IOStreams.ColorScheme() + help := "Use 'gh browse --help' for more information about browse\n" if err != nil { - fmt.Println("error") + fmt.Fprintf(w, "%s Navigate to a repository to open in browser\n%s", + cs.Red("x"), + help) return } + // ATTN: add into the empty string where you want to go within the repo repoUrl := ghrepo.GenerateRepoURL(baseRepo, "") f.Browser.Browse(repoUrl) + fmt.Fprintf(w, "%s Now opening %s in browser . . .\n%s", + cs.Green("✓"), + cs.Bold(ghrepo.FullName(baseRepo)), + help) } - -// Questions for tomorrow: -// if logged in / repo -// go to repo -// else if logged in / !repo -// go to profile -// else -// ? throw error / go to github home page