From da34d12abb099b9ea3e1093c6c8af6c0fecae4ad Mon Sep 17 00:00:00 2001 From: Alan Donovan Date: Fri, 27 Aug 2021 15:26:34 -0400 Subject: [PATCH] respond to review --- api/api.go | 2 +- cmd/ghcs/main.go | 3 --- cmd/ghcs/ports.go | 4 ++-- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/api/api.go b/api/api.go index 9d9eae79f..f534c4587 100644 --- a/api/api.go +++ b/api/api.go @@ -1,4 +1,4 @@ -// TODO(adonovan): rename to package codespaces, and codespaces.Client? +// TODO(adonovan): rename to package codespaces, and codespaces.Client. package api import ( diff --git a/cmd/ghcs/main.go b/cmd/ghcs/main.go index dbf1dc714..bc9bc2c6b 100644 --- a/cmd/ghcs/main.go +++ b/cmd/ghcs/main.go @@ -1,8 +1,5 @@ package main -// TODO(adonovan): write 'help' commands, in manner of the 'go' tool. -// Document GITHUB_TOKEN. - import ( "errors" "fmt" diff --git a/cmd/ghcs/ports.go b/cmd/ghcs/ports.go index c5d127892..c5088bfe6 100644 --- a/cmd/ghcs/ports.go +++ b/cmd/ghcs/ports.go @@ -83,8 +83,8 @@ func ports(opts *portsOptions) error { devContainerResult := <-devContainerCh if devContainerResult.err != nil { - _, _ = log.Errorf("Failed to get port names: %v\n", devContainerResult.err.Error()) - // TODO(adonovan): should this cause non-zero exit? + // Warn about failure to read the devcontainer file. Not a ghcs command error. + log.Errorf("Failed to get port names: %v\n", devContainerResult.err.Error()) } table := output.NewTable(os.Stdout, opts.asJSON)