STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #4705 from cli/jg/rename-errs

Browse source 
codespace: Rename errors from Live Share to generic codespace
This commit is contained in:
Jose Garcia 2021-11-09 07:42:14 -05:00 • committed by GitHub
commit db6e1d20cb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
internal/codespaces/states.go
View file

@ -43,7 +43,7 @@ func PollPostCreateStates(ctx context.Context, progress progressIndicator, apiCl
session, err := ConnectToLiveshare(ctx, progress, noopLogger, apiClient, codespace)
if err != nil {
return fmt.Errorf("connect to Live Share: %w", err)
return fmt.Errorf("connect to codespace: %w", err)
}
defer func() {
if closeErr := session.Close(); err == nil {

2
pkg/cmd/codespace/logs.go
View file

@ -53,7 +53,7 @@ func (a *App) Logs(ctx context.Context, codespaceName string, follow bool) (err
session, err := codespaces.ConnectToLiveshare(ctx, a, noopLogger(), a.apiClient, codespace)
if err != nil {
return fmt.Errorf("connecting to Live Share: %w", err)
return fmt.Errorf("connecting to codespace: %w", err)
}
defer safeClose(session, &err)

6
pkg/cmd/codespace/ports.go
View file

@ -59,7 +59,7 @@ func (a *App) ListPorts(ctx context.Context, codespaceName string, exporter cmdu
session, err := codespaces.ConnectToLiveshare(ctx, a, noopLogger(), a.apiClient, codespace)
if err != nil {
return fmt.Errorf("error connecting to Live Share: %w", err)
return fmt.Errorf("error connecting to codespace: %w", err)
}
defer safeClose(session, &err)
@ -245,7 +245,7 @@ func (a *App) UpdatePortVisibility(ctx context.Context, codespaceName string, ar
session, err := codespaces.ConnectToLiveshare(ctx, a, noopLogger(), a.apiClient, codespace)
if err != nil {
return fmt.Errorf("error connecting to Live Share: %w", err)
return fmt.Errorf("error connecting to codespace: %w", err)
}
defer safeClose(session, &err)
@ -321,7 +321,7 @@ func (a *App) ForwardPorts(ctx context.Context, codespaceName string, ports []st
session, err := codespaces.ConnectToLiveshare(ctx, a, noopLogger(), a.apiClient, codespace)
if err != nil {
return fmt.Errorf("error connecting to Live Share: %w", err)
return fmt.Errorf("error connecting to codespace: %w", err)
}
defer safeClose(session, &err)

2
pkg/cmd/codespace/ssh.go
View file

@ -85,7 +85,7 @@ func (a *App) SSH(ctx context.Context, sshArgs []string, opts sshOptions) (err e
session, err := codespaces.ConnectToLiveshare(ctx, a, liveshareLogger, a.apiClient, codespace)
if err != nil {
return fmt.Errorf("error connecting to Live Share: %w", err)
return fmt.Errorf("error connecting to codespace: %w", err)
}
defer safeClose(session, &err)