From dd5feda00a2357275fb2cc2d1b4eb854e882faed Mon Sep 17 00:00:00 2001 From: Mark Phelps Date: Fri, 25 Feb 2022 17:32:08 -0500 Subject: [PATCH] Update wording after consulting product --- pkg/cmd/codespace/create.go | 10 +++++----- pkg/cmd/codespace/create_test.go | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pkg/cmd/codespace/create.go b/pkg/cmd/codespace/create.go index 3f2ee0c35..b145a6a7d 100644 --- a/pkg/cmd/codespace/create.go +++ b/pkg/cmd/codespace/create.go @@ -155,17 +155,17 @@ func (a *App) handleAdditionalPermissions(ctx context.Context, createParams *api displayURL = utils.DisplayURL(allowPermissionsURL) ) - fmt.Fprintf(a.io.ErrOut, "You must accept or deny additional permissions requested by the repository before you can create a codespace.\n") + fmt.Fprintf(a.io.ErrOut, "You must authorize or deny additional permissions requested by this codespace before continuing.\n") if !isInteractive { - fmt.Fprintf(a.io.ErrOut, "%s to continue in your web browser to accept: %s\n", cs.Bold("Open this URL"), displayURL) - fmt.Fprintf(a.io.ErrOut, "Alternatively, you can run %q with the %q option to create the codespace without these additional permissions.\n", a.io.ColorScheme().Bold("create"), cs.Bold("--default-permissions")) + fmt.Fprintf(a.io.ErrOut, "%s in your browser to review and authorize additional permissions: %s\n", cs.Bold("Open this URL"), displayURL) + fmt.Fprintf(a.io.ErrOut, "Alternatively, you can run %q with the %q option to continue without authorizing additional permissions.\n", a.io.ColorScheme().Bold("create"), cs.Bold("--default-permissions")) return nil, cmdutil.SilentError } choices := []string{ - "Continue in browser to accept the additional permissions", - "Create the codespace without these additional permissions", + "Continue in browser to review and authorize additional permissions", + "Continue without authorizing additional permissions", } permsSurvey := []*survey.Question{ diff --git a/pkg/cmd/codespace/create_test.go b/pkg/cmd/codespace/create_test.go index 376f8c9eb..2d417620d 100644 --- a/pkg/cmd/codespace/create_test.go +++ b/pkg/cmd/codespace/create_test.go @@ -116,9 +116,9 @@ func TestApp_Create(t *testing.T) { idleTimeout: 30 * time.Minute, }, wantErr: cmdutil.SilentError, - wantStderr: `You must accept or deny additional permissions requested by the repository before you can create a codespace. -Open this URL to continue in your web browser to accept: example.com/permissions -Alternatively, you can run "create" with the "--default-permissions" option to create the codespace without these additional permissions. + wantStderr: `You must authorize or deny additional permissions requested by this codespace before continuing. +Open this URL in your browser to review and authorize additional permissions: example.com/permissions +Alternatively, you can run "create" with the "--default-permissions" option to continue without authorizing additional permissions. `, }, }