From 5b413da74545e0420c77398c7cd7c210638b3f50 Mon Sep 17 00:00:00 2001 From: 2017A7PS0125G Date: Sat, 19 Sep 2020 00:24:22 +0530 Subject: [PATCH 1/2] Emoji parsing in Readme content --- go.mod | 1 + go.sum | 2 ++ pkg/cmd/repo/view/view.go | 4 +++- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/go.mod b/go.mod index 47afd50ae..3b1788ef7 100644 --- a/go.mod +++ b/go.mod @@ -7,6 +7,7 @@ require ( github.com/MakeNowJust/heredoc v1.0.0 github.com/briandowns/spinner v1.11.1 github.com/charmbracelet/glamour v0.2.1-0.20200724174618-1246d13c1684 + github.com/enescakir/emoji v1.0.0 github.com/google/go-cmp v0.5.2 github.com/google/shlex v0.0.0-20191202100458-e7afc7fbc510 github.com/hashicorp/go-version v1.2.1 diff --git a/go.sum b/go.sum index f9f02eabe..e4ca820ec 100644 --- a/go.sum +++ b/go.sum @@ -46,6 +46,8 @@ github.com/dgrijalva/jwt-go v3.2.0+incompatible/go.mod h1:E3ru+11k8xSBh+hMPgOLZm github.com/dgryski/go-sip13 v0.0.0-20181026042036-e10d5fee7954/go.mod h1:vAd38F8PWV+bWy6jNmig1y/TA+kYO4g3RSRF0IAv0no= github.com/dlclark/regexp2 v1.2.0 h1:8sAhBGEM0dRWogWqWyQeIJnxjWO6oIjl8FKqREDsGfk= github.com/dlclark/regexp2 v1.2.0/go.mod h1:2pZnwuY/m+8K6iRw6wQdMtk+rH5tNGR1i55kozfMjCc= +github.com/enescakir/emoji v1.0.0 h1:W+HsNql8swfCQFtioDGDHCHri8nudlK1n5p2rHCJoog= +github.com/enescakir/emoji v1.0.0/go.mod h1:Bt1EKuLnKDTYpLALApstIkAjdDrS/8IAgTkKp+WKFD0= github.com/fatih/color v1.7.0 h1:DkWD4oS2D8LGGgTQ6IvwJJXSL5Vp2ffcQg58nFV38Ys= github.com/fatih/color v1.7.0/go.mod h1:Zm6kSWBoL9eyXnKyktHP6abPY2pDugNf5KwzbycvMj4= github.com/fsnotify/fsnotify v1.4.7/go.mod h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo= diff --git a/pkg/cmd/repo/view/view.go b/pkg/cmd/repo/view/view.go index 73051501a..67eca2eb4 100644 --- a/pkg/cmd/repo/view/view.go +++ b/pkg/cmd/repo/view/view.go @@ -16,6 +16,7 @@ import ( "github.com/cli/cli/pkg/iostreams" "github.com/cli/cli/utils" "github.com/spf13/cobra" + "github.com/enescakir/emoji" ) type ViewOptions struct { @@ -156,8 +157,9 @@ func viewRun(opts *ViewOptions) error { if err != nil { return fmt.Errorf("error rendering markdown: %w", err) } + readmeContent = emoji.Parse(readmeContent) } else { - readmeContent = readme.Content + readmeContent = emoji.Parse(readme.Content) } description := repo.Description From cd3e9c44cfb60a53c21b4af2d57012d99d89b8dc Mon Sep 17 00:00:00 2001 From: 2017A7PS0125G Date: Sat, 19 Sep 2020 00:59:35 +0530 Subject: [PATCH 2/2] gofmted file --- pkg/cmd/repo/view/view.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/cmd/repo/view/view.go b/pkg/cmd/repo/view/view.go index 67eca2eb4..e5dafa6fb 100644 --- a/pkg/cmd/repo/view/view.go +++ b/pkg/cmd/repo/view/view.go @@ -15,8 +15,8 @@ import ( "github.com/cli/cli/pkg/cmdutil" "github.com/cli/cli/pkg/iostreams" "github.com/cli/cli/utils" - "github.com/spf13/cobra" "github.com/enescakir/emoji" + "github.com/spf13/cobra" ) type ViewOptions struct {