STACKITGit/cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add TODO for better integer handling in GetPullRequestDatabaseID

Browse source
This commit is contained in:
Kynan Ware 2025-09-23 09:28:08 -06:00 • committed by GitHub
parent 8818c0d47c
commit e673dfe61c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
pkg/cmd/agent-task/capi/sessions.go
View file

@ -412,6 +412,13 @@ func (c *CAPIClient) hydrateSessionPullRequestsAndUsers(sessions []session) ([]*
// GetPullRequestDatabaseID retrieves the database ID and URL of a pull request given its number in a repository.
func (c *CAPIClient) GetPullRequestDatabaseID(ctx context.Context, hostname string, owner string, repo string, number int) (int64, string, error) {
// TODO: better int handling so we don't need to do bounds checks
// to both ensure a panic is impossible and that we do not trigger
// CodeQL alerts.
if number <= 0 || number > math.MaxInt32 {
return 0, "", fmt.Errorf("pull request number %d out of bounds", number)
}
var resp struct {
Repository struct {
PullRequest struct {