From 6d8af20e30174d542d2d63f290971e4048be25b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mislav=20Marohni=C4=87?= Date: Wed, 23 Oct 2019 22:35:11 +0200 Subject: [PATCH] Stop requiring vendored dependencies in CI We started vendoring dependencies because this was a practice that the Go community had for a while now to: 1. Speed up builds - no need to fetch dependencies every time; 2. Guard against 3rd-party downtime - CI passes even if hosts such as `gopkg.in` are down, or if someone deletes their GitHub repo/account hosting a particular module. With Go 1.13 and GitHub Actions, however, we have these problems solved for free: - The built-in goproxy caches dependencies and speeds up downloads; - Octofactory ensures that dependencies are cached on our own infrastructure, guarding us from 3rd-party downtime. With all this in mind, I feel that we don't have to require vendoring dependencies anymore. --- .github/workflows/go.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 3fae0b143..5e5521aa6 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -20,8 +20,6 @@ jobs: run: go mod verify - name: Build - env: - GOFLAGS: -mod=vendor run: | go test ./... go build -v .